diff options
author | Jesper Nilsson <[email protected]> | 2024-02-23 21:37:01 +0100 |
---|---|---|
committer | Paolo Abeni <[email protected]> | 2024-02-27 11:34:32 +0100 |
commit | d0dc1e42109da515db92901ca07270930f15d619 (patch) | |
tree | e663b43d7b6d5cae604efe4ed8c1ed57d62306b4 /scripts/generate_rust_analyzer.py | |
parent | 2322467a0f5d6cf05752092938e6db1250a0b28e (diff) |
net: stmmac: mmc_core: Drop interrupt registers from stats
The MMC IPC interrupt status and interrupt mask registers are
of little use as Ethernet statistics, but incrementing counters
based on the current interrupt and interrupt mask registers
makes them actively misleading.
For example, if the interrupt mask is set to 0x08420842,
the current code will increment by that amount each iteration,
leading to the following sequence of nonsense:
mmc_rx_ipc_intr_mask: 969816526
mmc_rx_ipc_intr_mask: 1108361744
These registers have been included in the Ethernet statistics
since the first version of MMC back in 2011 (commit 1c901a46d57).
That commit also mentions the MMC interrupts as
"something to add later (if actually useful)".
If the registers are actually useful, they should probably
be part of the Ethernet register dump instead of statistics,
but for now, drop the counters for mmc_rx_ipc_intr and
mmc_rx_ipc_intr_mask completely.
Reviewed-by: Serge Semin <[email protected]>
Signed-off-by: Jesper Nilsson <[email protected]>
Reviewed-by: Jiri Pirko <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Paolo Abeni <[email protected]>
Diffstat (limited to 'scripts/generate_rust_analyzer.py')
0 files changed, 0 insertions, 0 deletions