diff options
| author | Rafael Mendonca <[email protected]> | 2022-09-16 00:59:07 -0300 |
|---|---|---|
| committer | Martin K. Petersen <[email protected]> | 2022-10-18 02:42:08 +0000 |
| commit | dc8e483f684a24cc06e1d5fa958b54db58855093 (patch) | |
| tree | e86851eddf08f5e68f0a262354e5065e2fcdb10b /lib/mpi/mpi-sub-ui.c | |
| parent | 2331ce6126be8864b39490e705286b66e2344aac (diff) | |
scsi: lpfc: Fix memory leak in lpfc_create_port()
Commit 5e633302ace1 ("scsi: lpfc: vmid: Add support for VMID in mailbox
command") introduced allocations for the VMID resources in
lpfc_create_port() after the call to scsi_host_alloc(). Upon failure on the
VMID allocations, the new code would branch to the 'out' label, which
returns NULL without unwinding anything, thus skipping the call to
scsi_host_put().
Fix the problem by creating a separate label 'out_free_vmid' to unwind the
VMID resources and make the 'out_put_shost' label call only
scsi_host_put(), as was done before the introduction of allocations for
VMID.
Fixes: 5e633302ace1 ("scsi: lpfc: vmid: Add support for VMID in mailbox command")
Signed-off-by: Rafael Mendonca <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Reviewed-by: James Smart <[email protected]>
Signed-off-by: Martin K. Petersen <[email protected]>
Diffstat (limited to 'lib/mpi/mpi-sub-ui.c')
0 files changed, 0 insertions, 0 deletions