diff options
| author | Uday Shankar <[email protected]> | 2022-09-23 18:02:42 -0600 |
|---|---|---|
| committer | Martin K. Petersen <[email protected]> | 2022-10-18 02:26:29 +0000 |
| commit | 2331ce6126be8864b39490e705286b66e2344aac (patch) | |
| tree | 2622c427146c4e2d39fa3425884aaa447ad843c8 /lib/mpi/mpi-sub-ui.c | |
| parent | 9abf2313adc1ca1b6180c508c25f22f9395cc780 (diff) | |
scsi: core: Restrict legal sdev_state transitions via sysfs
Userspace can currently write to sysfs to transition sdev_state to RUNNING
or OFFLINE from any source state. This causes issues because proper
transitioning out of some states involves steps besides just changing
sdev_state, so allowing userspace to change sdev_state regardless of the
source state can result in inconsistencies; e.g. with ISCSI we can end up
with sdev_state == SDEV_RUNNING while the device queue is quiesced. Any
task attempting I/O on the device will then hang, and in more recent
kernels, iscsid will hang as well.
More detail about this bug is provided in my first attempt:
https://groups.google.com/g/open-iscsi/c/PNKca4HgPDs/m/CXaDkntOAQAJ
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Uday Shankar <[email protected]>
Suggested-by: Mike Christie <[email protected]>
Reviewed-by: Hannes Reinecke <[email protected]>
Signed-off-by: Martin K. Petersen <[email protected]>
Diffstat (limited to 'lib/mpi/mpi-sub-ui.c')
0 files changed, 0 insertions, 0 deletions