diff options
author | Toke Høiland-Jørgensen <[email protected]> | 2021-06-24 18:06:05 +0200 |
---|---|---|
committer | Daniel Borkmann <[email protected]> | 2021-06-24 19:45:39 +0200 |
commit | 4415db6ca85ae57830a83290388f2b9dfa5f237f (patch) | |
tree | 4aebaecb2b573bc46a658c3bada8b2385fe68638 /lib/mpi/mpi-sub-ui.c | |
parent | d5789621b658369b21bd13446bab8102cf75df65 (diff) |
qede: Remove rcu_read_lock() around XDP program invocation
The qede driver has rcu_read_lock()/rcu_read_unlock() pairs around XDP
program invocations. However, the actual lifetime of the objects referred
by the XDP program invocation is longer, all the way through to the call to
xdp_do_flush(), making the scope of the rcu_read_lock() too small. This
turns out to be harmless because it all happens in a single NAPI poll
cycle (and thus under local_bh_disable()), but it makes the rcu_read_lock()
misleading.
Rather than extend the scope of the rcu_read_lock(), just get rid of it
entirely. With the addition of RCU annotations to the XDP_REDIRECT map
types that take bh execution into account, lockdep even understands this to
be safe, so there's really no reason to keep it around.
Signed-off-by: Toke Høiland-Jørgensen <[email protected]>
Signed-off-by: Daniel Borkmann <[email protected]>
Cc: Ariel Elior <[email protected]>
Cc: [email protected]
Link: https://lore.kernel.org/bpf/[email protected]
Diffstat (limited to 'lib/mpi/mpi-sub-ui.c')
0 files changed, 0 insertions, 0 deletions