aboutsummaryrefslogtreecommitdiff
path: root/lib/mpi/mpi-sub-ui.c
diff options
context:
space:
mode:
authorToke Høiland-Jørgensen <[email protected]>2021-06-24 18:06:04 +0200
committerDaniel Borkmann <[email protected]>2021-06-24 19:45:26 +0200
commitd5789621b658369b21bd13446bab8102cf75df65 (patch)
treebc918a2b0cdaa5b22c9bcf5c0bac6b2c3a9ccdda /lib/mpi/mpi-sub-ui.c
parentc4411b371c104e65efb531ebd4d8892c568e3a29 (diff)
nfp: Remove rcu_read_lock() around XDP program invocation
The nfp driver has rcu_read_lock()/rcu_read_unlock() pairs around XDP program invocations. However, the actual lifetime of the objects referred by the XDP program invocation is longer, all the way through to the call to xdp_do_flush(), making the scope of the rcu_read_lock() too small. While this is not actually an issue for the nfp driver because it doesn't support XDP_REDIRECT (and thus doesn't call xdp_do_flush()), the rcu_read_lock() is still unneeded. And With the addition of RCU annotations to the XDP_REDIRECT map types that take bh execution into account, lockdep even understands this to be safe, so there's really no reason to keep it around. Signed-off-by: Toke Høiland-Jørgensen <[email protected]> Signed-off-by: Daniel Borkmann <[email protected]> Reviewed-by: Simon Horman <[email protected]> Cc: [email protected] Link: https://lore.kernel.org/bpf/[email protected]
Diffstat (limited to 'lib/mpi/mpi-sub-ui.c')
0 files changed, 0 insertions, 0 deletions