aboutsummaryrefslogtreecommitdiff
path: root/drivers/pci/controller/dwc/pci-exynos.c
diff options
context:
space:
mode:
authorMarek Szyprowski <m.szyprowski@samsung.com>2022-06-29 00:04:08 +0200
committerBjorn Helgaas <bhelgaas@google.com>2022-08-01 15:25:12 -0500
commitf2812227bb07e2eaee74253f11cea1576945df31 (patch)
treebd20216d600efa7ed7a7aeb6d442273d5aa8dc13 /drivers/pci/controller/dwc/pci-exynos.c
parent91a773f9986b5cb4d6a6610b0326ef7c472dd543 (diff)
phy: samsung: phy-exynos-pcie: sanitize init/power_on callbacks
The exynos-pcie driver called phy_power_on() before phy_init() for some historical reasons. However the generic PHY framework assumes that the proper sequence is to call phy_init() first, then phy_power_on(). The operations done by both functions should be considered as one action and as such they are called by the exynos-pcie driver (without doing anything between them). The initialization is just a sequence of register writes, which cannot be altered without breaking the hardware operation. To match the generic PHY framework requirement, simply move all register writes to the phy_init()/phy_exit() and drop power_on()/power_off() callbacks. This way the driver will also work with the old (incorrect) PHY initialization call sequence. Link: https://lore.kernel.org/r/20220628220409.26545-1-m.szyprowski@samsung.com Reported-by: Bjorn Helgaas <helgaas@kernel.org> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Chanho Park <chanho61.park@samsung.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Acked-By: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/pci/controller/dwc/pci-exynos.c')
0 files changed, 0 insertions, 0 deletions