diff options
| author | Zhen Lei <[email protected]> | 2024-08-07 17:00:56 +0800 |
|---|---|---|
| committer | Paul Moore <[email protected]> | 2024-08-07 15:14:36 -0400 |
| commit | 6dd1e4c045afa6a4ba5d46f044c83bd357c593c2 (patch) | |
| tree | 63721438df336be9a4a7fa8c61bf0ccbde4c61f4 | |
| parent | 379d9af3f3da2da1bbfa67baf1820c72a080d1f1 (diff) | |
selinux: add the processing of the failure of avc_add_xperms_decision()
When avc_add_xperms_decision() fails, the information recorded by the new
avc node is incomplete. In this case, the new avc node should be released
instead of replacing the old avc node.
Cc: [email protected]
Fixes: fa1aa143ac4a ("selinux: extended permissions for ioctls")
Suggested-by: Stephen Smalley <[email protected]>
Signed-off-by: Zhen Lei <[email protected]>
Acked-by: Stephen Smalley <[email protected]>
Signed-off-by: Paul Moore <[email protected]>
| -rw-r--r-- | security/selinux/avc.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/security/selinux/avc.c b/security/selinux/avc.c index 7087cd2b802d..b49c44869dc4 100644 --- a/security/selinux/avc.c +++ b/security/selinux/avc.c @@ -907,7 +907,11 @@ static int avc_update_node(u32 event, u32 perms, u8 driver, u8 xperm, u32 ssid, node->ae.avd.auditdeny &= ~perms; break; case AVC_CALLBACK_ADD_XPERMS: - avc_add_xperms_decision(node, xpd); + rc = avc_add_xperms_decision(node, xpd); + if (rc) { + avc_node_kill(node); + goto out_unlock; + } break; } avc_node_replace(node, orig); |