diff options
| author | Zhen Lei <[email protected]> | 2024-08-06 14:51:13 +0800 |
|---|---|---|
| committer | Paul Moore <[email protected]> | 2024-08-06 17:52:27 -0400 |
| commit | 379d9af3f3da2da1bbfa67baf1820c72a080d1f1 (patch) | |
| tree | 82bf6a3939395672440a30bd4a33dbcacb4186c6 | |
| parent | 8400291e289ee6b2bf9779ff1c83a291501f017b (diff) | |
selinux: fix potential counting error in avc_add_xperms_decision()
The count increases only when a node is successfully added to
the linked list.
Cc: [email protected]
Fixes: fa1aa143ac4a ("selinux: extended permissions for ioctls")
Signed-off-by: Zhen Lei <[email protected]>
Acked-by: Stephen Smalley <[email protected]>
Signed-off-by: Paul Moore <[email protected]>
| -rw-r--r-- | security/selinux/avc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/security/selinux/avc.c b/security/selinux/avc.c index 32eb67fb3e42..7087cd2b802d 100644 --- a/security/selinux/avc.c +++ b/security/selinux/avc.c @@ -330,12 +330,12 @@ static int avc_add_xperms_decision(struct avc_node *node, { struct avc_xperms_decision_node *dest_xpd; - node->ae.xp_node->xp.len++; dest_xpd = avc_xperms_decision_alloc(src->used); if (!dest_xpd) return -ENOMEM; avc_copy_xperms_decision(&dest_xpd->xpd, src); list_add(&dest_xpd->xpd_list, &node->ae.xp_node->xpd_head); + node->ae.xp_node->xp.len++; return 0; } |