aboutsummaryrefslogtreecommitdiff
path: root/sound/pci/echoaudio/midi.c
AgeCommit message (Collapse)AuthorFilesLines
2022-04-05ALSA: echoaudio: remove redundant assignment to variable iColin Ian King1-1/+0
The variable i is being assigned a value that is never read, it is being re-assigned in the following for-loop. The assignment is redundant and can be removed. Signed-off-by: Colin Ian King <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
2022-03-04ALSA: echoaudio: remove redundant assignment to variable bytesColin Ian King1-1/+1
The variable bytes is being assigned a value that is never read, it is being re-assigned inside a following if block. The assignment is redundant and can be removed. Cleans up clang scan build warning: sound/pci/echoaudio/midi.c:211:9: warning: Although the value stored to 'bytes' is used in the enclosing expression, the value is never actually read from 'bytes' [deadcode.DeadStores] Signed-off-by: Colin Ian King <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
2021-06-09ALSA: echoaudio: Fix assignment in if conditionTakashi Iwai1-2/+2
PCI echoaudio drivers contain a few assignments in if condition, which is a bad coding style that may confuse readers and occasionally lead to bugs. This patch is merely for coding-style fixes, no functional changes. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Takashi Iwai <[email protected]>
2017-10-26ALSA: Convert timers to use timer_setup()Kees Cook1-5/+5
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. These are all the "mechanical" changes remaining in the sound subsystem. Signed-off-by: Kees Cook <[email protected]> Acked-by: Mark Brown <[email protected]> Signed-off-by: Takashi Iwai <[email protected]>
2017-01-12ALSA: pci: Constify snd_rawmidi_opsTakashi Iwai1-2/+2
Now snd_rawmidi_ops is maintained as a const pointer in snd_rawmidi, we can constify the definitions. Reviewed-by: Takashi Sakamoto <[email protected]> Signed-off-by: Takashi Iwai <[email protected]>
2015-01-19ALSA: echoaudio: Use setup_timer() and mod_timer()Takashi Iwai1-3/+2
No functional change, refactoring with the standard helpers. Signed-off-by: Takashi Iwai <[email protected]>
2014-11-05ALSA: echoaudio: cleanup of unnecessary messagesSudip Mukherjee1-6/+0
commit "b5b4a41b392960010fccf1f9ccf8334d612bd450" was dereferencing chip after it has been freed. This patch fixes that and at the same time removes some debugging messages, which are unnecessary, as they are just printing information about entry and exit from a function, and which switch-case it is executing. we can easily get from ftrace the information about the entry and exit from a function. Reported-by: Dan Carpenter <[email protected]> Signed-off-by: Sudip Mukherjee <[email protected]> Signed-off-by: Takashi Iwai <[email protected]>
2014-11-03ALSA: echoaudio: remove all snd_printkSudip Mukherjee1-14/+15
removed all references of snd_printk with the standard dev_* macro. [a few places degraded to dev_dbg(), too -- tiwai] Signed-off-by: Sudip Mukherjee <[email protected]> Signed-off-by: Takashi Iwai <[email protected]>
2014-02-26ALSA: echoaudio: Use standard printk helpersTakashi Iwai1-1/+2
Convert with dev_err() and co from snd_printk(), etc. Signed-off-by: Takashi Iwai <[email protected]>
2012-12-07ALSA: pci: remove __dev* attributesBill Pemberton1-2/+2
CONFIG_HOTPLUG is going away as an option. As result the __dev* markings will be going away. Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst, and __devexit. Signed-off-by: Bill Pemberton <[email protected]> Signed-off-by: Takashi Iwai <[email protected]>
2009-02-12ALSA: echoaudio - replace uses of __constant_{endian}Harvey Harrison1-2/+2
The base versions handle constant folding now. Signed-off-by: Harvey Harrison <[email protected]> Signed-off-by: Takashi Iwai <[email protected]>
2008-08-13ALSA: Kill snd_assert() in sound/pci/*Takashi Iwai1-2/+4
Kill snd_assert() in sound/pci/*, either removed or replaced with if () with snd_BUG_ON(). Signed-off-by: Takashi Iwai <[email protected]> Signed-off-by: Jaroslav Kysela <[email protected]>
2007-01-09[ALSA] Fix potential NULL pointer dereference in echoaudio midiGiuliano Pochini1-2/+4
Fix races between the timer handler and the close function. Signed-off-by: Giuliano Pochini <[email protected]> Signed-off-by: Takashi Iwai <[email protected]> Signed-off-by: Jaroslav Kysela <[email protected]>
2006-06-28[ALSA] Fix a typo in echoaudio/midi.cTakashi Iwai1-1/+1
Fixed a typo in echoaudio/midi.c. Signed-off-by: Takashi Iwai <[email protected]> Signed-off-by: Jaroslav Kysela <[email protected]>
2006-06-28[ALSA] Add echoaudio sound driversGiuliano Pochini1-0/+327
From: Giuliano Pochini <[email protected]>Add echoaudio sound drivers (darla20, darla24, echo3g, gina20, gina24, indigo, indigodj, indigoio, layla20, lala24, mia, mona) Signed-off-by: Takashi Iwai <[email protected]> Signed-off-by: Jaroslav Kysela <[email protected]>
Powered by cgit, Gruvboxed by Blaster4385.