aboutsummaryrefslogtreecommitdiff
path: root/drivers/staging/skein
AgeCommit message (Collapse)AuthorFilesLines
2018-07-02staging/skein: Remove Skein and Threefish codeJason Cooper14-11412/+0
It's been four years since this was added. In the interim, skein has not seen any mainstream adoption. Same with the threefish block cipher upon which it's based. In the discussion over which hash algorithm will replace SHA1 in git, it's not one of the contenders. There's absolutely no reason to think that there is anything wrong with Skein or Threefish. The only reason for this removal is a lack of adoption. If a real user comes forward, I'd be happy to assist with integrating this code into mainline. Signed-off-by: Jason Cooper <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-11-02License cleanup: add SPDX GPL-2.0 license identifier to files with no licenseGreg Kroah-Hartman5-0/+5
Many source files in the tree are missing licensing information, which makes it harder for compliance tools to determine the correct license. By default all files without license information are under the default license of the kernel, which is GPL version 2. Update the files which contain no license information with the 'GPL-2.0' SPDX license identifier. The SPDX identifier is a legally binding shorthand, which can be used instead of the full boiler plate text. This patch is based on work done by Thomas Gleixner and Kate Stewart and Philippe Ombredanne. How this work was done: Patches were generated and checked against linux-4.14-rc6 for a subset of the use cases: - file had no licensing information it it. - file was a */uapi/* one with no licensing information in it, - file was a */uapi/* one with existing licensing information, Further patches will be generated in subsequent months to fix up cases where non-standard license headers were used, and references to license had to be inferred by heuristics based on keywords. The analysis to determine which SPDX License Identifier to be applied to a file was done in a spreadsheet of side by side results from of the output of two independent scanners (ScanCode & Windriver) producing SPDX tag:value files created by Philippe Ombredanne. Philippe prepared the base worksheet, and did an initial spot review of a few 1000 files. The 4.13 kernel was the starting point of the analysis with 60,537 files assessed. Kate Stewart did a file by file comparison of the scanner results in the spreadsheet to determine which SPDX license identifier(s) to be applied to the file. She confirmed any determination that was not immediately clear with lawyers working with the Linux Foundation. Criteria used to select files for SPDX license identifier tagging was: - Files considered eligible had to be source code files. - Make and config files were included as candidates if they contained >5 lines of source - File already had some variant of a license header in it (even if <5 lines). All documentation files were explicitly excluded. The following heuristics were used to determine which SPDX license identifiers to apply. - when both scanners couldn't find any license traces, file was considered to have no license information in it, and the top level COPYING file license applied. For non */uapi/* files that summary was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 11139 and resulted in the first patch in this series. If that file was a */uapi/* path one, it was "GPL-2.0 WITH Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was: SPDX license identifier # files ---------------------------------------------------|------- GPL-2.0 WITH Linux-syscall-note 930 and resulted in the second patch in this series. - if a file had some form of licensing information in it, and was one of the */uapi/* ones, it was denoted with the Linux-syscall-note if any GPL family license was found in the file or had no licensing in it (per prior point). Results summary: SPDX license identifier # files ---------------------------------------------------|------ GPL-2.0 WITH Linux-syscall-note 270 GPL-2.0+ WITH Linux-syscall-note 169 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21 ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17 LGPL-2.1+ WITH Linux-syscall-note 15 GPL-1.0+ WITH Linux-syscall-note 14 ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5 LGPL-2.0+ WITH Linux-syscall-note 4 LGPL-2.1 WITH Linux-syscall-note 3 ((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3 ((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1 and that resulted in the third patch in this series. - when the two scanners agreed on the detected license(s), that became the concluded license(s). - when there was disagreement between the two scanners (one detected a license but the other didn't, or they both detected different licenses) a manual inspection of the file occurred. - In most cases a manual inspection of the information in the file resulted in a clear resolution of the license that should apply (and which scanner probably needed to revisit its heuristics). - When it was not immediately clear, the license identifier was confirmed with lawyers working with the Linux Foundation. - If there was any question as to the appropriate license identifier, the file was flagged for further research and to be revisited later in time. In total, over 70 hours of logged manual review was done on the spreadsheet to determine the SPDX license identifiers to apply to the source files by Kate, Philippe, Thomas and, in some cases, confirmation by lawyers working with the Linux Foundation. Kate also obtained a third independent scan of the 4.13 code base from FOSSology, and compared selected files where the other two scanners disagreed against that SPDX file, to see if there was new insights. The Windriver scanner is based on an older version of FOSSology in part, so they are related. Thomas did random spot checks in about 500 files from the spreadsheets for the uapi headers and agreed with SPDX license identifier in the files he inspected. For the non-uapi files Thomas did random spot checks in about 15000 files. In initial set of patches against 4.14-rc6, 3 files were found to have copy/paste license identifier errors, and have been fixed to reflect the correct identifier. Additionally Philippe spent 10 hours this week doing a detailed manual inspection and review of the 12,461 patched files from the initial patch version early this week with: - a full scancode scan run, collecting the matched texts, detected license ids and scores - reviewing anything where there was a license detected (about 500+ files) to ensure that the applied SPDX license was correct - reviewing anything where there was no detection but the patch license was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied SPDX license was correct This produced a worksheet with 20 files needing minor correction. This worksheet was then exported into 3 different .csv files for the different types of files to be modified. These .csv files were then reviewed by Greg. Thomas wrote a script to parse the csv files and add the proper SPDX tag to the file, in the format that the file expected. This script was further refined by Greg based on the output to detect more types of files automatically and to distinguish between header and source .c files (which need different comment types.) Finally Greg ran the script using the .csv files to generate the patches. Reviewed-by: Kate Stewart <[email protected]> Reviewed-by: Philippe Ombredanne <[email protected]> Reviewed-by: Thomas Gleixner <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-07-28staging: skein: move macros into header fileDmytro Shynkevych2-323/+323
Move macro definitions from source file into respective header file This concludes macro cleanup as outlined in TODO Signed-off-by: Dmytro Shynkevych <[email protected]> Acked-by: Jason Cooper <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-01-20staging: skein: fix checkpatch block comments warningAbdul Rauf4-89/+99
Fix the following warnings: Block comments should align the * on each line Signed-off-by: Abdul Rauf <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2017-01-03Staging: skein: checkpatch: fix comment aligning in skein_base.cTobias Heineken1-8/+8
This is a patch to the skein_base.c file that fixes up a comment aligning warning found by the checkpatch.pl tool at line 2 Signed-off-by: Tobias Heineken <[email protected]> Signed-off-by: Florian Schleicher <[email protected]> CC: [email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-11-21staging: skein: threefish_block.c Remove blank linesWalt Feasel1-16/+0
Make suggested checkpatch modification for CHECK: Please don't use multiple blank lines Acked-by: Jason Cooper <[email protected] Signed-off-by: Walt Feasel <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-10-16Staging: skein: skein_api: Remove useless type conversionBhumika Goyal1-16/+10
Some type conversions like casting a pointer to a pointer of same type, casting to the original type using addressof(&) operator etc. are not needed. Therefore, remove them. Done using coccinelle: @@ type t; t *p; t a; @@ ( - (t)(a) + a | - (t *)(p) + p | - (t *)(&a) + &a ) Signed-off-by: Bhumika Goyal <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-05-03staging: skein: cleanup: align code to parenthesesManu Kumar1-6/+6
Align wrapped lines to parentheses (if applicable). Signed-off-by: Manu Kumar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-05-03staging: skein: cleanup: removed unnecessary cast spacesManu Kumar4-19/+19
Spaces after casts are removed Signed-off-by: Manu Kumar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-05-03staging: skein: cleanup: Fixed operator whitespaceManu Kumar2-16/+16
added operator white space and parentheses for readability Signed-off-by: Manu Kumar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-05-03staging: skein: cleanup: fixed new linesManu Kumar2-2/+3
Added lines between functions in skein_block.c and removed unneeded lines in skein_block.c Signed-off-by: Manu Kumar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-04-29staging: skein: cleanup: align parenthesesManu Kumar2-10/+10
Aligned parentheses to conform to the coding style. Signed-off-by: Manu Kumar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-04-29staging: skein: cleanup: add operator white spaceManu Kumar4-69/+73
Added white space between operators and operands. Because this sometimes maxed out the column width, some expressions were broken up into multiple lines, and comments were moved appropriately. Signed-off-by: Manu Kumar <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-29staging: skein: Convert local rotl_64 to kernel's rol64Joe Perches2-19/+16
Remove the local inline and use the generic kernel rol64 instead. Miscellanea: o Added a newline between a multiple line macro for consistency with the other multiple line macros Signed-off-by: Joe Perches <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-28staging: skein: threefish_block: Use ror64Joe Perches1-1072/+1072
Use the inline instead of direct code to improve readability and shorten the code a little. Done with perl: $ perl -p -i -e 's/\((\w+) \>\> (\d+)\) \| \(\1 \<\< \(64 \- \2\)\)/ror64(\1, \2)/g' drivers/staging/skein/threefish_block.c Signed-off-by: Joe Perches <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2016-03-11staging: skein: threefish_block: Use rol64Joe Perches1-1072/+1073
Use the inline instead of direct code to improve readability and shorten the code a little. Signed-off-by: Joe Perches <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2015-10-24skein: fix coding styleAnton Tatuev1-4/+4
Added spaces around binary operators. Signed-off-by: Tatuev Anton <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2015-10-24staging: skein: Add space around '%'Burcin Akalin1-1/+1
Add space around operator '%'. Problem found using checkpatch.pl CHECK: spaces preferred around that '%' (ctx:VxV) Signed-off-by: Burcin Akalin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2015-10-16staging: skein: Remove useless initialisationAmitoj Kaur Chawla1-1/+1
Remove intialisation of a variable that is immediately reassigned. The semantic patch used to find this is: // <smpl> @@ type T; identifier x; constant C; expression e; @@ T x - = C ; x = e; // </smpl> Signed-off-by: Amitoj Kaur Chawla <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2015-10-13Staging: skein: Remove NULL comparisonAybuke Ozdemir1-3/+3
Problem found using checkpatch.pl CHECK: Comparison to NULL could be written "key" Signed-off-by: Aybuke Ozdemir <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2015-10-12Staging: skein: Remove space after castAybuke Ozdemir1-1/+1
Remove unnecessary space after cast. Problem found using checkpatch.pl CHECK: No space is necessary after a cast. Signed-off-by: Aybuke Ozdemir <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2015-10-12Staging: skein: Remove multiple blank linesAybuke Ozdemir1-1/+0
Remove multiple blank lines. Problem found using checkpatch.pl CHECK: Please don't use multiple blank lines. Signed-off-by: Aybuke Ozdemir <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2015-10-12staging: skein: remove extra indentationDeepa Dinamani1-189/+189
Fix macros containing do/while blocks to be indented uniformly. This patch fixes the checkpatch.pl warning: WARNING: suspect code indent for conditional statements Signed-off-by: Deepa Dinamani <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2015-10-12staging: skein: fix block comment styleDeepa Dinamani2-30/+35
Use a separate line for the opening marker of a comment block, a leading asterisk in front of subsequent lines in the block comment, and a separate line for the closing marker of the comment block. This patch fixes the checkpatch.pl warnings: WARNING: Block comments use a trailing */ on a separate line WARNING: Block comments use * on subsequent lines Signed-off-by: Deepa Dinamani <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2015-09-21staging: skein: Adds * on subsequent lines in block commentAmber N. Adams1-24/+24
This patch fixes the checkpatch.pl warning: WARNING: Block comments use * on subsequent lines +/* +Copyright (c) 2010 Werner Dittmann Signed-off-by: Amber N. Adams <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2015-05-31Drivers: staging: skein: skein_api: Fixed spelling errorsColin Cronin1-3/+3
Fixed a few spelling errors in comments. Signed-off-by: Colin Cronin <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2015-03-15Staging: skein: Remove do-while(0) from single statement macrosVatika Harlalka1-6/+2
Remove unneeded do-while(0) loop from single statement macros. Signed-off-by: Vatika Harlalka <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2015-01-17staging: skein: Fixing single statement macro checkpatch warningMathieu Poirier1-13/+4
WARNING: Single statement macros should not use a do {} while (0) loop Signed-off-by: Mathieu Poirier <[email protected]> Acked-by: Jason Cooper <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2015-01-17staging: skein: Fixing trailing whitespace errorMathieu Poirier1-1/+0
Signed-off-by: Mathieu Poirier <[email protected]> Acked-by: Jason Cooper <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-22staging: skein: fix sparse warnings related to shift operatorDomagoj Trsan1-1/+1
Fix warnings: drivers/staging/skein/skein_base.h:89:30: warning: shift too big (50) for type int ... drivers/staging/skein/skein_base.h:89:30: warning: shift too big (39)for type int drivers/staging/skein/skein_base.h:89:19: warning: too many warnings Signed-off-by: Domagoj Trsan <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-11-22staging: skein: fixed sparse warnings related to static declarationsNiklas Svensson1-3/+3
drivers/staging/skein/skein_generic.c:30:5: warning: symbol 'skein256_update' was not declared. Should it be static? drivers/staging/skein/skein_generic.c:65:5: warning: symbol 'skein512_update' was not declared. Should it be static? drivers/staging/skein/skein_generic.c:100:5: warning: symbol 'skein1024_update' was not declared. Should it be static? Signed-off-by: Niklas Svensson <[email protected]> Acked-by: Jason Cooper <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-10-30staging: skein: Removes skein_debug includeEric Rost3-85/+1
Removes skein_debug.h include since skein_debug.h is nonexistent. Removes unneeded debug empty macro defines and their uses. Signed-off-by: Eric Rost <[email protected]> Reviewed-by: Jason Cooper <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-10-29staging: skein: skein_api.c: removed space before ','Mikael Svantesson1-1/+1
Signed-off-by: Mikael Svantesson <[email protected]> Acked-by: Jason Cooper <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-10-29staging: skein: Removes unneeded #defineEric Rost1-2/+0
Removes unneeded #define SKEIN_PORT_CODE since skein_port.h is nonexistent. Signed-off-by: Eric Rost <[email protected]> Reviewed-by: Jason Cooper <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-10-29staging: skein: Inlines rotl_64Eric Rost1-9/+10
Inlines the rotl_64 macro. Signed-off-by: Eric Rost <[email protected]> Reviewed-by: Jason Cooper <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-10-29staging: skein: Adds Loadable Module SupportEric Rost3-8/+26
Adds loadable module support to the Skein Hashing Algorithm driver. Signed-off-by: Eric Rost <[email protected]> Reviewed-by: Jason Cooper <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-10-29staging: skein: Adds CryptoAPI SupportEric Rost3-1/+206
Adds CryptoAPI support to the Skein Hashing Algorithm driver. Signed-off-by: Eric Rost <[email protected]> Reviewed-by: Jason Cooper <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-10-29staging: skein: Renames skein to skein_baseEric Rost8-7/+8
Renames skein.c to skein_base.c and skein.h to skein_base.h in preparation for naming loadable module skein.ko Signed-off-by: Eric Rost <[email protected]> Reviewed-by: Jason Cooper <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-10-29staging: skein: Collapses threefish moduleEric Rost2-25/+8
Collapses threefish module into skein module. Signed-off-by: Eric Rost <[email protected]> Reviewed-by: Jason Cooper <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-10-20staging: skein: File ReorgEric Rost1-326/+348
Reorganizes file to remove #defines from middle of functions. Also removes #if'd loop declarations and adds ternary if driven loops. Signed-off-by: Eric Rost <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-10-20staging: skein: Whitespace cleanupEric Rost1-270/+315
Pretties up multiline #defines and many other whitespace issues Signed-off-by: Eric Rost <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-09-19staging: skein: replace spaces with tabsBlaj Roxana1-1/+1
This fixes the error and warning: ERROR: code indent should use tabs where possible WARNING: please, no spaces at the start of a line Signed-off-by: Blaj Roxana <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-06-19staging: skein: fix sparse warning for static arraysJames A Shackleford1-13/+13
This patch fixes the following sparse warnings: skein_iv.h:23:11: warning: symbol 'SKEIN_256_IV_128' was not declared. Should it be static? skein_iv.h:31:11: warning: symbol 'SKEIN_256_IV_160' was not declared. Should it be static? skein_iv.h:39:11: warning: symbol 'SKEIN_256_IV_224' was not declared. Should it be static? skein_iv.h:47:11: warning: symbol 'SKEIN_256_IV_256' was not declared. Should it be static? skein_iv.h:55:11: warning: symbol 'SKEIN_512_IV_128' was not declared. Should it be static? skein_iv.h:67:11: warning: symbol 'SKEIN_512_IV_160' was not declared. Should it be static? skein_iv.h:79:11: warning: symbol 'SKEIN_512_IV_224' was not declared. Should it be static? skein_iv.h:91:11: warning: symbol 'SKEIN_512_IV_256' was not declared. Should it be static? skein_iv.h:103:11: warning: symbol 'SKEIN_512_IV_384' was not declared. Should it be static? skein_iv.h:115:11: warning: symbol 'SKEIN_512_IV_512' was not declared. Should it be static? skein_iv.h:127:11: warning: symbol 'SKEIN_1024_IV_384' was not declared. Should it be static? skein_iv.h:147:11: warning: symbol 'SKEIN_1024_IV_512' was not declared. Should it be static? skein_iv.h:167:11: warning: symbol 'SKEIN_1024_IV_1024' was not declared. Should it be static? by declaring the initialization vectors in question as static. The header skein_iv.h is only included by skein.c Signed-off-by: James A Shackleford <[email protected]> Acked-by: Jason Cooper <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-06-01staging: skein: fix sparse warning for static declarationsJames A Shackleford1-0/+1
This patch fixes the following sparse warnings: skein_block.c:43:6: warning: symbol 'skein_256_process_block' was not declared. Should it be static? skein_block.c:252:6: warning: symbol 'skein_512_process_block' was not declared. Should it be static? skein_block.c:483:6: warning: symbol 'skein_1024_process_block' was not declared. Should it be static? by including the header skein_block.h, which contains the declarations in question. Signed-off-by: James A Shackleford <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-05-21staging/skein: variable/member name cleanupJake Edge5-185/+186
Rename a few more variables and structure member names to lower case. Signed-off-by: Jake Edge <[email protected]> Acked-by: Jason Cooper <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-05-21staging/skein: comment typosJake Edge1-9/+9
fix some comment typos Signed-off-by: Jake Edge <[email protected]> Acked-by: Jason Cooper <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-05-21staging/skein: move all threefish block functions to one fileJake Edge4-3368/+3358
move all threefish block functions to one file, remove unneeded include Signed-off-by: Jake Edge <[email protected]> Acked-by: Jason Cooper <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-05-19staging/skein: rename files and clean up directory structureJake Edge15-201/+21
Clean up file names and locations. Get rid of include/ directory and move those up to the top-level. Rename files to get rid of upper case. Remove skeinBlockNo3F.c as it was unused (temporary file or something?). Signed-off-by: Jake Edge <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-05-19staging: crypto: skein: rename macrosAnton Saraev8-352/+353
Mixing upper and lower case in names of macros like It_Is_Macro is not accepted in the Linux Kernel. To prepare skein driver for mainline inclusion, we rename all macros to uppercase or lowercase names. Signed-off-by: Anton Saraev <[email protected]> Reviewed-by: Jake Edge <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
2014-05-19staging: crypto: skein: rename enumsAnton Saraev7-40/+40
Linux Kernel use capitalized names for enum. To prepare skein driver to mainline inclusion, we rename all enums to capitalized names. Signed-off-by: Anton Saraev <[email protected]> Reviewed-by: Jake Edge <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
Powered by cgit, Gruvboxed by Blaster4385.