| Age | Commit message (Collapse) | Author | Files | Lines |
|
This subsystem isn't used anymore, and the hardware isn't around. It's
been in staging for a while, and it's time for it to now be removed.
Cc: Alan Cox <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
drivers/staging/i2o/iop.c:777:1-3: WARNING: end returns can be simpified
Simplify a trivial if-return sequence. Possibly combine with a
preceding function call.
Generated by: scripts/coccinelle/misc/simple_return.cocci
CC: Alan Cox <[email protected]>
Signed-off-by: Fengguang Wu <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch removes unwanted semicolon around close braces of code blocks
Signed-off-by: Hari Prasath <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
We should not be doing assignments within an if () block
so fix up the code to not do this.
change was created using Coccinelle.
CC: Supriya Karanth <[email protected]>
CC: Somya Anand <[email protected]>
CC: Alan Cox <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch fixes the checkpatche.pl warnings:
WARNING: labels should not be indented
+ context_remove:
WARNING: labels should not be indented
+ nop_msg:
WARNING: labels should not be indented
+ exit:
Signed-off-by: Helen Fornazier <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The semantic patch that makes this change is available
in scripts/coccinelle/api/kstrdup.cocci
Signed-off-by: Abdul Hussain S <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Checkpatch.pl suggest to avoid assignment in if statement.
This patch moves assignments out of the if statement and place
it before the if statement. This is done using following coccinelle
script.
@@
expression E1;
identifier p;
statement S;
@@
- if ((p = E1))
+ p = E1;
+ if (p)
S
Signed-off-by: Somya Anand <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
static ints are initialized to 0 by the compiler.
Explicit initialization is not necessary.
Found by checkpatch.pl - ERROR: do not initialise statics to 0 or NULL
changes made using coccinelle script:
@@
type T;
identifier var;
@@
static T var
- =0
;
Signed-off-by: Supriya Karanth <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The seq_printf return value, because it's frequently misused,
will eventually be converted to void.
See: commit 1f33c41c03da ("seq_file: Rename seq_overflow() to
seq_has_overflowed() and make public")
Signed-off-by: Joe Perches <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch fixes "quoted string split across lines warning" warning in
exec-osm.c
Signed-off-by: Dilek Uzulmez <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch fixes the checkpatch.pl warning:
WARNING: "Missing a blank line after declarations"
Signed-off-by: Yeliz Taneroglu <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The following patch fixes the checkpatch.pl warning:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: Yeliz Taneroglu <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
Brackets were removed from the expression that containing single
statement. Removed following checkpatch.pl warnings:
WARNING: braces {} are not necessary for single statement blocks
Signed-off-by: aybuke ozdemir <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch removes unnecessay out of memory message fixing the following
checkpach.pl warning in device.c
Signed-off-by: aybuke ozdemir <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch fixes the following checkpatch.pl warning:
Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
Signed-off-by: Aya Mahfouz <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch fixes the following checkpatch.pl warning:
Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
Signed-off-by: Aya Mahfouz <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch removes the checkpatch.pl warnings "quoted string split accross lines"
Signed-off-by: Vatika Harlalka <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch is to remove space after the * in pointer type function parameters
in function prototype and definition to follow kernel coding conventions.
Signed-off-by: Vatika Harlalka <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch fixes checkpatch.pl error in debug.c
ERROR: do not use C99 // comments
Signed-off-by: Vatika Harlalka <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
This patch fixes checkpatch.pl warning "Use #include
<linux/uaccess.h> instead of <asm/uaccess.h>" in i2o/config-osm.c .
Signed-off-by: Vatika Harlalka <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|
|
The I2O layer deals with a technology that to say the least didn't catch on
in the market.
The only relevant products are some of the AMI MegaRAID - which supported I2O
and its native mode (The native mode is faster and runs on Linux), an
obscure crypto ethernet card that's now so many years out of date nobody
would use it, the old DPT controllers, which speak their own dialect and
have their own driver - and ermm.. thats about it.
We also know the code isn't in good shape as recently a patch was proposed
and queried as buggy, which in turn showed the existing code was broken
already by prior "clean up" and nobody had noticed that either.
It's coding style robot code nothing more. Like some forgotten corridor
cleaned relentlessly by a lost Roomba but where no user has trodden in years.
Move it to staging and then to /dev/null.
The headers remain as they are shared with dpt_i2o.
Signed-off-by: Alan Cox <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
|