aboutsummaryrefslogtreecommitdiff
path: root/drivers/staging/exfat
AgeCommit message (Collapse)AuthorFilesLines
2020-03-10staging: exfat: remove staging version of exfat filesystemGreg Kroah-Hartman10-8309/+0
Now that there is a "real" solution for exfat in the vfs tree queued up to be merged in 5.7-rc1 the "old" exfat code in staging can be removed. Many thanks to Valdis for doing the work to get this into the tree in the first place, it was greatly appreciated. Acked-by: Valdis Kletnieks <[email protected]> Cc: Pali Rohár <[email protected]> Cc: Stephen Rothwell <[email protected]> Cc: Al Viro <[email protected]> Cc: Namjae Jeon <[email protected]> Cc: Sungjong Seo <[email protected]> Cc: Christoph Hellwig <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-03-10staging: exfat: alignment should match open parenthesisPayal Kshirsagar1-2/+2
Align code to match open parenthesis. Signed-off-by: Payal Kshirsagar <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-03-10staging: exfat: exfat_super.c: remove commented out functionLourdes Pedrajas1-77/+0
Remove function ffsSetAttr() which is unused. Signed-off-by: Lourdes Pedrajas <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-03-04staging: exfat: remove redundant if statementsTetsuhiro Kohada1-5/+2
If statement does not affect results when updating directory entry in ffsMapCluster(). Signed-off-by: Tetsuhiro Kohada <[email protected]> Link: https://lore.kernel.org/r/20200302095716.64155-2-Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-03-04staging: exfat: clean up d_entry rebuilding.Tetsuhiro Kohada1-15/+10
Clean up d_entry rebuilding in exfat_rename_file() and move_file(). -Replace memcpy of d_entry with structure copy. -Change to use the value already stored in fid. Signed-off-by: Tetsuhiro Kohada <[email protected]> Acked-by: Valdis Kletnieks <[email protected]> Link: https://lore.kernel.org/r/20200302095716.64155-1-Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-03-04staging: exfat: remove 'file creation modes'Tetsuhiro Kohada3-11/+7
The mode parameter in ffsCreateFile() and create_file() is redundant. Remove it and definition. Signed-off-by: Tetsuhiro Kohada <[email protected]> Link: https://lore.kernel.org/r/20200228084037.15123-1-Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-03-04Staging: exfat: fixed a long line coding style issuevivek m1-3/+5
Fixed a coding style issue Signed-off-by: Vivek M <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-03-04staging: exfat: rename buf_cache_t's 'flag' to 'locked'Tetsuhiro Kohada2-16/+13
buf_cache_t.flag is used only for lock. Change the variable name from 'flag' to 'locked' and remove unused definitions. Reviewed-by: Takahiro Mori <[email protected]> Signed-off-by: Tetsuhiro Kohada <[email protected]> Link: https://lore.kernel.org/r/20200227104043.11503-1-Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-03-04staging: exfat: remove symlink featureTetsuhiro Kohada3-33/+0
Completely remove symlink codes and definitions. In the previous patch, it was not completely removed. Reviewed-by: Takahiro Mori <[email protected]> Signed-off-by: Tetsuhiro Kohada <[email protected]> Link: https://lore.kernel.org/r/20200227061559.4481-1-Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-02-23staging: exfat: remove exfat_buf_sync()Kaaira Gupta2-20/+0
exfat_buf_sync() is not called anywhere, hence remove it from exfat_cache.c and exfat.h Signed-off-by: Kaaira Gupta <[email protected]> Link: https://lore.kernel.org/r/20200223191623.GA20122@kaaira-HP-Pavilion-Notebook Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-02-23staging: exfat: remove sync_alloc_bitmap()Kaaira Gupta2-13/+0
sync_alloc_bitmap() is not called anywhere, hence remove it from exfat_core.c and exfat.h Signed-off-by: Kaaira Gupta <[email protected]> Link: https://lore.kernel.org/r/20200223192347.GA20286@kaaira-HP-Pavilion-Notebook Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-02-23staging: exfat: remove exfat_fat_sync()Kaaira Gupta2-20/+0
exfat_fat_sync() is not called anywhere, hence remove it from exfat_cache.c and exfat.h Acked-by: Valdis Kletnieks <[email protected]> Signed-off-by: Kaaira Gupta <[email protected]> Link: https://lore.kernel.org/r/20200219161738.GA22282@kaaira-HP-Pavilion-Notebook Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-02-23staging: exfat: remove symlink feature.Tetsuhiro Kohada1-450/+0
Remove symlink feature completely. Becouse -Uses reserved areas(defined in the Microsoft exfat specification), causing future incompatibilities. -Not described in Microsoft exfat specifications or SD standards. -For REMOVABLE media, causes incompatibility with other implementations. -Not supported by other major exfat drivers. -Not implemented symlink feature in linux FAT/VFAT. Remove this feature completely because of serious media compatibility issues. (Can't enable even with CONFIG) If you have any questions about this patch, please let me know. Reviewed-by: Takahiro Mori <[email protected]> Acked-by: Valdis Kletnieks <[email protected]> Signed-off-by: Tetsuhiro Kohada <[email protected]> Link: https://lore.kernel.org/r/20200219055727.12867-1-Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-02-17staging: exfat: dedicate count_entries() to sub-dir counting.Tetsuhiro Kohada3-9/+5
count_entries() function is only used to count sub-dirs. Clarify the role and rename to count_dir_entries(). Signed-off-by: Tetsuhiro Kohada <[email protected]> Link: https://lore.kernel.org/r/20200217072941.34116-2-Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-02-17staging: exfat: remove DOSNAMEs.Tetsuhiro Kohada3-103/+33
remove 'dos_name','short_name' and related definitions. 'dos_name' and 'short_name' are definitions before VFAT. These are never used in exFAT. Signed-off-by: Tetsuhiro Kohada <[email protected]> Link: https://lore.kernel.org/r/20200217072941.34116-1-Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-02-11staging: exfat: Rename variable 'AccessTimestamp' to 'access_timestamp'Pragat Pandya2-6/+6
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "AccessTimestamp" to "access_timestamp" Signed-off-by: Pragat Pandya <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-02-11staging: exfat: Rename variable 'ModifyTimestamp' to 'modify_timestamp'Pragat Pandya2-24/+24
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "ModifyTimestamp" to "modify_timestamp" Signed-off-by: Pragat Pandya <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-02-11staging: exfat: Rename variable 'CreateTimestamp' to 'create_timestamp'Pragat Pandya2-24/+24
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "CreateTimestamp" to "create_timestamp" Signed-off-by: Pragat Pandya <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-02-11staging: exfat: Rename variable 'NumSubdirs' to 'num_subdirs'Pragat Pandya2-6/+6
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "NumSubdirs" to "num_subdirs" Signed-off-by: Pragat Pandya <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-02-11staging: exfat: Rename variable 'Attr' to 'attr'Pragat Pandya2-13/+13
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "Attr" to "attr" Signed-off-by: Pragat Pandya <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-02-11staging: exfat: Rename variable 'ShortName' to 'short_name'Pragat Pandya2-4/+4
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "ShortName" to "short_name" Signed-off-by: Pragat Pandya <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-02-11staging: exfat: Rename variable 'Name' to 'name'Pragat Pandya2-7/+7
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "Name" to "name" Signed-off-by: Pragat Pandya <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-02-11staging: exfat: Rename variable 'MilliSecond' to 'millisecond'Pragat Pandya2-9/+9
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "MilliSecond" to "millisecond" Signed-off-by: Pragat Pandya <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-02-11staging: exfat: Rename variable 'Second' to 'second'Pragat Pandya2-11/+11
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "Second" to "second" Signed-off-by: Pragat Pandya <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-02-11staging: exfat: Rename variable 'Minute' to 'minute'Pragat Pandya2-11/+11
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "Minute" to "minute" Signed-off-by: Pragat Pandya <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-02-11staging: exfat: Rename variable 'Hour' to 'hour'Pragat Pandya2-11/+11
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "Hour" to "hour" Signed-off-by: Pragat Pandya <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-02-11staging: exfat: Rename variable 'Day' to 'day'Pragat Pandya2-11/+11
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "Day" to "day" Signed-off-by: Pragat Pandya <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-02-11staging: exfat: Rename variable 'Month' to 'month'Pragat Pandya2-11/+11
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "Month" to "month" Signed-off-by: Pragat Pandya <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-02-11staging: exfat: Rename variable 'Year' to 'year'Pragat Pandya2-11/+11
Fix checkpatch warning: Avoid CamelCase Change all occurrences of identifier "Year" to "year" Signed-off-by: Pragat Pandya <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-02-10staging: exfat: Replace printk with pr_infoJieunKim1-1/+1
pr_info is preferred to use than printk. pr_info calls printk with KERN_INFO macros by itself. Signed-off-by: JieunKim <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-02-09staging: exfat: Remove unused struct 'dev_info_t'Pragat Pandya1-5/+0
Remove global declaration of unused struct "dev_info_t". Structure "dev_info_t" is defined in exfat.h and not referenced in any other file. Signed-off-by: Pragat Pandya <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-02-09staging: exfat: Remove unused struct 'part_info_t'Pragat Pandya1-5/+0
Remove global declaration of unused struct "part_info_t". Structure "part_info_t" is defined in exfat.h and not referenced in any other file. Signed-off-by: Pragat Pandya <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-02-09staging: exfat: remove 'vol_type' variable.Tetsuhiro Kohada3-60/+27
remove 'vol_type' variable. The following issues are described in exfat's TODO. > clean up the remaining vol_type checks, which are of two types: > some are ?: operators with magic numbers, and the rest are places > where we're doing stuff with '.' and '..'. The vol_type variable is always set to 'EXFAT'. The variable checks are unnessesary, so remove unused code. Signed-off-by: Tetsuhiro Kohada <[email protected]> Reviewed-by: Mori Takahiro <[email protected]> Suggested-by: Dan Carpenter <[email protected]> Reviewed-by: Dan Carpenter <[email protected]> Link: https://lore.kernel.org/r/20200130070614.11999-1-Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-01-23staging: exfat: remove fs_func struct.Tetsuhiro Kohada3-234/+178
Remove 'fs_func struct' and change indirect calls to direct calls. The following issues are described in exfat's TODO. > Create helper function for exfat_set_entry_time () and > exfat_set_entry_type () because it's sort of ugly to be calling the same functionn directly and other code calling through the fs_func struc ponters ... The fs_func struct was used for switching the helper functions of fat16/fat32/exfat. Now, it has lost the role of switching, just making the code less readable. Signed-off-by: Tetsuhiro Kohada <[email protected]> Link: https://lore.kernel.org/r/20200123102445.123033-1-Kohada.Tetsuhiro@dc.MitsubishiElectric.co.jp Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-01-14staging: exfat: Fix alignment warningsPragat Pandya3-17/+18
Fix checkpatch warning "Alignment should match open parenthesis". Signed-off-by: Pragat Pandya <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2020-01-03staging: exfat: add STAGING prefix to config namesNamjae Jeon6-56/+56
Add STAGING prefix to config names to avoid collsion with fs/exfat config. Signed-off-by: Namjae Jeon <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-12-16Merge 5.5-rc2 into staging-nextGreg Kroah-Hartman3-8/+10
We want the staging driver fixes in here, and this resolves merge issues with the isdn code that was pointed out in linux-next Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-12-10staging: exfat: fix multiple definition error of `rename_file'Brendan Higgins3-6/+6
`rename_file' was exported but not properly namespaced causing a multiple definition error because `rename_file' is already defined in fs/hostfs/hostfs_user.c: ld: drivers/staging/exfat/exfat_core.o: in function `rename_file': drivers/staging/exfat/exfat_core.c:2327: multiple definition of `rename_file'; fs/hostfs/hostfs_user.o:fs/hostfs/hostfs_user.c:350: first defined here make: *** [Makefile:1077: vmlinux] Error 1 This error can be reproduced on ARCH=um by selecting: CONFIG_EXFAT_FS=y CONFIG_HOSTFS=y Add a namespace prefix exfat_* to fix this error. Reported-by: Brendan Higgins <[email protected]> Signed-off-by: Brendan Higgins <[email protected]> Cc: stable <[email protected]> Cc: Valdis Kletnieks <[email protected]> Tested-by: David Gow <[email protected]> Reviewed-by: David Gow <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-12-10staging: exfat: properly support discard in clr_alloc_bitmap()Andrea Righi1-2/+4
Currently the discard code in clr_alloc_bitmap() is just dead code. Move code around so that the discard operation is properly attempted when enabled. Signed-off-by: Andrea Righi <[email protected]> Link: https://lore.kernel.org/r/20191205152913.GJ3276@xps-13 Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-12-10staging: exfat: fix spelling mistakeSusarla Nikhilesh1-2/+2
CHECK: 'propogate' may be misspelled - perhaps 'propagate'? FILE: drivers/staging/exfat/exfat_super.c:1484 CHECK: 'propogate' may be misspelled - perhaps 'propagate'? FILE: drivers/staging/exfat/exfat_super.c:1551 Signed-off-by: Susarla Nikhilesh <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-11-15staging: exfat: fix spelling mistake "maont" -> "mount"Colin Ian King1-1/+1
There is a spelling mistake in a kernel info message. Fix it. Signed-off-by: Colin Ian King <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-11-15staging: exfat: remove two unused functionsYueHaibing1-35/+0
Fix sparse warnings: drivers/staging/exfat/exfat_core.c:2045:4: warning: symbol 'calc_checksum_1byte' was not declared. Should it be static? drivers/staging/exfat/exfat_core.c:2080:5: warning: symbol 'calc_checksum_4byte' was not declared. Should it be static? The two functions has no caller in tree, so remove it. Reported-by: Hulk Robot <[email protected]> Signed-off-by: YueHaibing <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-11-14staging: exfat: fix indentation issueColin Ian King1-1/+1
There is a declaration that requires indentation. Add in the missing tab. Signed-off-by: Colin Ian King <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-11-13staging: exfat: Update the TODO fileValdis Kletnieks1-11/+59
Updating with the current laundry list of things that need attention. Signed-off-by: Valdis Kletnieks <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-11-13staging: exfat: Clean up the namespace pollution part 8Valdis Kletnieks4-51/+51
Rename all the FAT_* functions to exfat_fat_*. Signed-off-by: Valdis Kletnieks <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-11-13staging: exfat: Clean up the namespace pollution part 7Valdis Kletnieks4-74/+74
Global functions called 'buf*' are a linkage editor disaster waiting to happen. Rename our buf_* functions to exfat_buf_* Signed-off-by: Valdis Kletnieks <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-11-13staging: exfat: Clean up the namespace pollution part 6Valdis Kletnieks2-93/+85
Move a few more things so we can make them static and clear exfat.h out. At this point, pretty much everything that can be static is static. (Note: FAT_sync(), buf_sync(), and sync_alloc_bitmap() aren't called anyplace, but aren't static because (a) that will toss an error and (b) they probably *should* be getting called someplace Signed-off-by: Valdis Kletnieks <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-11-13staging: exfat: Clean up the namespace pollution part 5Valdis Kletnieks2-94/+91
Some more functions that can be moved and made static Signed-off-by: Valdis Kletnieks <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-11-13staging: exfat: Clean up the namespace pollution part 4Valdis Kletnieks2-43/+39
Relocating these functions to before first use lets us make them static Signed-off-by: Valdis Kletnieks <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
2019-11-13staging: exfat: Clean up the namespace pollution part 3Valdis Kletnieks2-10/+4
These functions are only used in the local file, make them static Signed-off-by: Valdis Kletnieks <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Greg Kroah-Hartman <[email protected]>
Powered by cgit, Gruvboxed by Blaster4385.