diff options
Diffstat (limited to 'net/dsa')
| -rw-r--r-- | net/dsa/master.c | 62 | ||||
| -rw-r--r-- | net/dsa/port.c | 90 | ||||
| -rw-r--r-- | net/dsa/slave.c | 5 | 
3 files changed, 134 insertions, 23 deletions
| diff --git a/net/dsa/master.c b/net/dsa/master.c index 90e6df0351eb..c90ee3227dea 100644 --- a/net/dsa/master.c +++ b/net/dsa/master.c @@ -22,7 +22,7 @@ static void dsa_master_get_ethtool_stats(struct net_device *dev,  	int port = cpu_dp->index;  	int count = 0; -	if (ops && ops->get_sset_count && ops->get_ethtool_stats) { +	if (ops->get_sset_count && ops->get_ethtool_stats) {  		count = ops->get_sset_count(dev, ETH_SS_STATS);  		ops->get_ethtool_stats(dev, stats, data);  	} @@ -31,6 +31,32 @@ static void dsa_master_get_ethtool_stats(struct net_device *dev,  		ds->ops->get_ethtool_stats(ds, port, data + count);  } +static void dsa_master_get_ethtool_phy_stats(struct net_device *dev, +					     struct ethtool_stats *stats, +					     uint64_t *data) +{ +	struct dsa_port *cpu_dp = dev->dsa_ptr; +	const struct ethtool_ops *ops = cpu_dp->orig_ethtool_ops; +	struct dsa_switch *ds = cpu_dp->ds; +	int port = cpu_dp->index; +	int count = 0; + +	if (dev->phydev && !ops->get_ethtool_phy_stats) { +		count = phy_ethtool_get_sset_count(dev->phydev); +		if (count >= 0) +			phy_ethtool_get_stats(dev->phydev, stats, data); +	} else if (ops->get_sset_count && ops->get_ethtool_phy_stats) { +		count = ops->get_sset_count(dev, ETH_SS_PHY_STATS); +		ops->get_ethtool_phy_stats(dev, stats, data); +	} + +	if (count < 0) +		count = 0; + +	if (ds->ops->get_ethtool_phy_stats) +		ds->ops->get_ethtool_phy_stats(ds, port, data + count); +} +  static int dsa_master_get_sset_count(struct net_device *dev, int sset)  {  	struct dsa_port *cpu_dp = dev->dsa_ptr; @@ -38,11 +64,17 @@ static int dsa_master_get_sset_count(struct net_device *dev, int sset)  	struct dsa_switch *ds = cpu_dp->ds;  	int count = 0; -	if (ops && ops->get_sset_count) -		count += ops->get_sset_count(dev, sset); +	if (sset == ETH_SS_PHY_STATS && dev->phydev && +	    !ops->get_ethtool_phy_stats) +		count = phy_ethtool_get_sset_count(dev->phydev); +	else if (ops->get_sset_count) +		count = ops->get_sset_count(dev, sset); + +	if (count < 0) +		count = 0; -	if (sset == ETH_SS_STATS && ds->ops->get_sset_count) -		count += ds->ops->get_sset_count(ds, cpu_dp->index); +	if (ds->ops->get_sset_count) +		count += ds->ops->get_sset_count(ds, cpu_dp->index, sset);  	return count;  } @@ -64,19 +96,28 @@ static void dsa_master_get_strings(struct net_device *dev, uint32_t stringset,  	/* We do not want to be NULL-terminated, since this is a prefix */  	pfx[sizeof(pfx) - 1] = '_'; -	if (ops && ops->get_sset_count && ops->get_strings) { -		mcount = ops->get_sset_count(dev, ETH_SS_STATS); +	if (stringset == ETH_SS_PHY_STATS && dev->phydev && +	    !ops->get_ethtool_phy_stats) { +		mcount = phy_ethtool_get_sset_count(dev->phydev); +		if (mcount < 0) +			mcount = 0; +		else +			phy_ethtool_get_strings(dev->phydev, data); +	} else if (ops->get_sset_count && ops->get_strings) { +		mcount = ops->get_sset_count(dev, stringset); +		if (mcount < 0) +			mcount = 0;  		ops->get_strings(dev, stringset, data);  	} -	if (stringset == ETH_SS_STATS && ds->ops->get_strings) { +	if (ds->ops->get_strings) {  		ndata = data + mcount * len;  		/* This function copies ETH_GSTRINGS_LEN bytes, we will mangle  		 * the output after to prepend our CPU port prefix we  		 * constructed earlier  		 */ -		ds->ops->get_strings(ds, port, ndata); -		count = ds->ops->get_sset_count(ds, port); +		ds->ops->get_strings(ds, port, stringset, ndata); +		count = ds->ops->get_sset_count(ds, port, stringset);  		for (i = 0; i < count; i++) {  			memmove(ndata + (i * len + sizeof(pfx)),  				ndata + i * len, len - sizeof(pfx)); @@ -102,6 +143,7 @@ static int dsa_master_ethtool_setup(struct net_device *dev)  	ops->get_sset_count = dsa_master_get_sset_count;  	ops->get_ethtool_stats = dsa_master_get_ethtool_stats;  	ops->get_strings = dsa_master_get_strings; +	ops->get_ethtool_phy_stats = dsa_master_get_ethtool_phy_stats;  	dev->ethtool_ops = ops; diff --git a/net/dsa/port.c b/net/dsa/port.c index 7acc1169d75e..2413beb995be 100644 --- a/net/dsa/port.c +++ b/net/dsa/port.c @@ -273,25 +273,38 @@ int dsa_port_vlan_del(struct dsa_port *dp,  	return 0;  } -static int dsa_port_setup_phy_of(struct dsa_port *dp, bool enable) +static struct phy_device *dsa_port_get_phy_device(struct dsa_port *dp)  { -	struct device_node *port_dn = dp->dn;  	struct device_node *phy_dn; -	struct dsa_switch *ds = dp->ds;  	struct phy_device *phydev; -	int port = dp->index; -	int err = 0; -	phy_dn = of_parse_phandle(port_dn, "phy-handle", 0); +	phy_dn = of_parse_phandle(dp->dn, "phy-handle", 0);  	if (!phy_dn) -		return 0; +		return NULL;  	phydev = of_phy_find_device(phy_dn);  	if (!phydev) { -		err = -EPROBE_DEFER; -		goto err_put_of; +		of_node_put(phy_dn); +		return ERR_PTR(-EPROBE_DEFER);  	} +	return phydev; +} + +static int dsa_port_setup_phy_of(struct dsa_port *dp, bool enable) +{ +	struct dsa_switch *ds = dp->ds; +	struct phy_device *phydev; +	int port = dp->index; +	int err = 0; + +	phydev = dsa_port_get_phy_device(dp); +	if (!phydev) +		return 0; + +	if (IS_ERR(phydev)) +		return PTR_ERR(phydev); +  	if (enable) {  		err = genphy_config_init(phydev);  		if (err < 0) @@ -317,8 +330,6 @@ static int dsa_port_setup_phy_of(struct dsa_port *dp, bool enable)  err_put_dev:  	put_device(&phydev->mdio.dev); -err_put_of: -	of_node_put(phy_dn);  	return err;  } @@ -372,3 +383,60 @@ void dsa_port_link_unregister_of(struct dsa_port *dp)  	else  		dsa_port_setup_phy_of(dp, false);  } + +int dsa_port_get_phy_strings(struct dsa_port *dp, uint8_t *data) +{ +	struct phy_device *phydev; +	int ret = -EOPNOTSUPP; + +	if (of_phy_is_fixed_link(dp->dn)) +		return ret; + +	phydev = dsa_port_get_phy_device(dp); +	if (IS_ERR_OR_NULL(phydev)) +		return ret; + +	ret = phy_ethtool_get_strings(phydev, data); +	put_device(&phydev->mdio.dev); + +	return ret; +} +EXPORT_SYMBOL_GPL(dsa_port_get_phy_strings); + +int dsa_port_get_ethtool_phy_stats(struct dsa_port *dp, uint64_t *data) +{ +	struct phy_device *phydev; +	int ret = -EOPNOTSUPP; + +	if (of_phy_is_fixed_link(dp->dn)) +		return ret; + +	phydev = dsa_port_get_phy_device(dp); +	if (IS_ERR_OR_NULL(phydev)) +		return ret; + +	ret = phy_ethtool_get_stats(phydev, NULL, data); +	put_device(&phydev->mdio.dev); + +	return ret; +} +EXPORT_SYMBOL_GPL(dsa_port_get_ethtool_phy_stats); + +int dsa_port_get_phy_sset_count(struct dsa_port *dp) +{ +	struct phy_device *phydev; +	int ret = -EOPNOTSUPP; + +	if (of_phy_is_fixed_link(dp->dn)) +		return ret; + +	phydev = dsa_port_get_phy_device(dp); +	if (IS_ERR_OR_NULL(phydev)) +		return ret; + +	ret = phy_ethtool_get_sset_count(phydev); +	put_device(&phydev->mdio.dev); + +	return ret; +} +EXPORT_SYMBOL_GPL(dsa_port_get_phy_sset_count); diff --git a/net/dsa/slave.c b/net/dsa/slave.c index 18561af7a8f1..f3fb3a0880b1 100644 --- a/net/dsa/slave.c +++ b/net/dsa/slave.c @@ -560,7 +560,8 @@ static void dsa_slave_get_strings(struct net_device *dev,  		strncpy(data + 2 * len, "rx_packets", len);  		strncpy(data + 3 * len, "rx_bytes", len);  		if (ds->ops->get_strings) -			ds->ops->get_strings(ds, dp->index, data + 4 * len); +			ds->ops->get_strings(ds, dp->index, stringset, +					     data + 4 * len);  	}  } @@ -605,7 +606,7 @@ static int dsa_slave_get_sset_count(struct net_device *dev, int sset)  		count = 4;  		if (ds->ops->get_sset_count) -			count += ds->ops->get_sset_count(ds, dp->index); +			count += ds->ops->get_sset_count(ds, dp->index, sset);  		return count;  	} |