aboutsummaryrefslogtreecommitdiff
path: root/usr
diff options
context:
space:
mode:
authorBreno Leitao <leitao@debian.org>2024-04-11 12:22:32 -0700
committerJakub Kicinski <kuba@kernel.org>2024-04-15 11:19:53 -0700
commit4ba67ef3a1fbb7d8dc5f00de9b93a583d05b38cc (patch)
treec35d85cdf08a651df1049f026d4e6c4eb2dcd178 /usr
parent721f076b62cb05108565adf17c27875ef5015307 (diff)
net: dqs: make struct dql more cache efficient
With the previous change, struct dqs->stall_thrs will be in the hot path (at queue side), even if DQS is disabled. The other fields accessed in this function (last_obj_cnt and num_queued) are in the first cache line, let's move this field (stall_thrs) to the very first cache line, since there is a hole there. This does not change the structure size, since it moves an short (2 bytes) to 4-bytes whole in the first cache line. This is the new structure format now: struct dql { unsigned int num_queued; unsigned int last_obj_cnt; ... short unsigned int stall_thrs; /* XXX 2 bytes hole, try to pack */ ... /* --- cacheline 1 boundary (64 bytes) --- */ ... /* Longest stall detected, reported to user */ short unsigned int stall_max; /* XXX 2 bytes hole, try to pack */ }; Also, read the stall_thrs (now in the very first cache line) earlier, together with dql->num_queued (also in the first cache line). Suggested-by: Jakub Kicinski <kuba@kernel.org> Suggested-by: Eric Dumazet <edumazet@google.com> Signed-off-by: Breno Leitao <leitao@debian.org> Link: https://lore.kernel.org/r/20240411192241.2498631-5-leitao@debian.org Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'usr')
0 files changed, 0 insertions, 0 deletions