diff options
| author | Chris Wilson <chris@chris-wilson.co.uk> | 2018-06-10 20:43:09 +0100 |
|---|---|---|
| committer | Jani Nikula <jani.nikula@intel.com> | 2018-06-19 15:47:37 +0300 |
| commit | 7ba33e1c9d1e03f442b161c701d1f811ea13c75e (patch) | |
| tree | 3ae98b64efd0dbf9fc7a3c2ec2243ffda897bbf2 /tools/vm/page_owner_sort.c | |
| parent | ce397d215ccd07b8ae3f71db689aedb85d56ab40 (diff) | |
drm/i915: Apply batch location restrictions before pinning
We special case the position of the batch within the GTT to prevent
negative self-relocation deltas from underflowing. However, that
restriction is being applied after a trial pin of the batch in its
current position. Thus we are not rejecting an invalid location if the
batch has been used before, leading to an assertion if we happen to need
to rearrange the entire payload. In the worst case, this may cause a GPU
hang on gen7 or perhaps missing state.
References: https://bugs.freedesktop.org/show_bug.cgi?id=105720
Fixes: 2889caa92321 ("drm/i915: Eliminate lots of iterations over the execobjects array")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Martin Peres <martin.peres@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180610194325.13467-2-chris@chris-wilson.co.uk
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
(cherry picked from commit 746c8f143afad7aaa66c484485fc39888d437a3f)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Diffstat (limited to 'tools/vm/page_owner_sort.c')
0 files changed, 0 insertions, 0 deletions