diff options
author | Peter Xu <[email protected]> | 2024-04-17 17:18:35 -0400 |
---|---|---|
committer | Andrew Morton <[email protected]> | 2024-04-24 19:34:25 -0700 |
commit | b76b46902c2d0395488c8412e1116c2486cdfcb2 (patch) | |
tree | 2cac9e74a99592a3f3cea9edbf891d88bcd31331 /tools/testing/selftests/bpf/progs/test_autoload.c | |
parent | 6db7412c142006985a15765785cf6c0c0dd75374 (diff) |
mm/hugetlb: fix missing hugetlb_lock for resv uncharge
There is a recent report on UFFDIO_COPY over hugetlb:
https://lore.kernel.org/all/[email protected]/
350: lockdep_assert_held(&hugetlb_lock);
Should be an issue in hugetlb but triggered in an userfault context, where
it goes into the unlikely path where two threads modifying the resv map
together. Mike has a fix in that path for resv uncharge but it looks like
the locking criteria was overlooked: hugetlb_cgroup_uncharge_folio_rsvd()
will update the cgroup pointer, so it requires to be called with the lock
held.
Link: https://lkml.kernel.org/r/[email protected]
Fixes: 79aa925bf239 ("hugetlb_cgroup: fix reservation accounting")
Signed-off-by: Peter Xu <[email protected]>
Reported-by: [email protected]
Reviewed-by: Mina Almasry <[email protected]>
Cc: David Hildenbrand <[email protected]>
Cc: <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Diffstat (limited to 'tools/testing/selftests/bpf/progs/test_autoload.c')
0 files changed, 0 insertions, 0 deletions