diff options
| author | Chengfeng Ye <dg573847474@gmail.com> | 2023-12-07 12:34:53 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-12-09 21:17:45 +0000 |
| commit | 15319a4e8ee4b098118591c6ccbd17237f841613 (patch) | |
| tree | 367efa884182102f12cf52c46e093ff62db23fa8 /tools/testing/selftests/bpf/prog_tests/recursion.c | |
| parent | d5dba32b8f6cb39be708b726044ba30dbc088b30 (diff) | |
atm: solos-pci: Fix potential deadlock on &tx_queue_lock
As &card->tx_queue_lock is acquired under softirq context along the
following call chain from solos_bh(), other acquisition of the same
lock inside process context should disable at least bh to avoid double
lock.
<deadlock #2>
pclose()
--> spin_lock(&card->tx_queue_lock)
<interrupt>
--> solos_bh()
--> fpga_tx()
--> spin_lock(&card->tx_queue_lock)
This flaw was found by an experimental static analysis tool I am
developing for irq-related deadlock.
To prevent the potential deadlock, the patch uses spin_lock_bh()
on &card->tx_queue_lock under process context code consistently to
prevent the possible deadlock scenario.
Fixes: 213e85d38912 ("solos-pci: clean up pclose() function")
Signed-off-by: Chengfeng Ye <dg573847474@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'tools/testing/selftests/bpf/prog_tests/recursion.c')
0 files changed, 0 insertions, 0 deletions