diff options
| author | Xu Kuohai <xukuohai@huawei.com> | 2022-10-11 08:01:05 -0400 |
|---|---|---|
| committer | Andrii Nakryiko <andrii@kernel.org> | 2022-10-13 10:53:22 -0700 |
| commit | 6e8280b958c5d7edc514cf347a800b23b7732b2b (patch) | |
| tree | dd89061a3f008f63487277a0f3ed2710b2aae3ec /tools/testing/selftests/bpf/prog_tests/map_kptr.c | |
| parent | 0dc9254e03704c75f2ebc9cbef2ce4de83fba603 (diff) | |
selftests/bpf: Fix memory leak caused by not destroying skeleton
Some test cases does not destroy skeleton object correctly, causing ASAN
to report memory leak warning. Fix it.
Fixes: 0ef6740e9777 ("selftests/bpf: Add tests for kptr_ref refcounting")
Fixes: 1642a3945e22 ("selftests/bpf: Add struct argument tests with fentry/fexit programs.")
Signed-off-by: Xu Kuohai <xukuohai@huawei.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Acked-by: Martin KaFai Lau <martin.lau@kernel.org>
Link: https://lore.kernel.org/bpf/20221011120108.782373-4-xukuohai@huaweicloud.com
Diffstat (limited to 'tools/testing/selftests/bpf/prog_tests/map_kptr.c')
| -rw-r--r-- | tools/testing/selftests/bpf/prog_tests/map_kptr.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/tools/testing/selftests/bpf/prog_tests/map_kptr.c b/tools/testing/selftests/bpf/prog_tests/map_kptr.c index fdcea7a61491..0d66b1524208 100644 --- a/tools/testing/selftests/bpf/prog_tests/map_kptr.c +++ b/tools/testing/selftests/bpf/prog_tests/map_kptr.c @@ -105,7 +105,7 @@ static void test_map_kptr_success(bool test_run) ASSERT_OK(opts.retval, "test_map_kptr_ref2 retval"); if (test_run) - return; + goto exit; ret = bpf_map__update_elem(skel->maps.array_map, &key, sizeof(key), buf, sizeof(buf), 0); @@ -132,6 +132,7 @@ static void test_map_kptr_success(bool test_run) ret = bpf_map__delete_elem(skel->maps.lru_hash_map, &key, sizeof(key), 0); ASSERT_OK(ret, "lru_hash_map delete"); +exit: map_kptr__destroy(skel); } |