diff options
author | Hao Xu <haoxu@linux.alibaba.com> | 2021-09-22 18:12:36 +0800 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2021-09-24 10:24:34 -0600 |
commit | bd99c71bd14072ce2920f6d0c2fe43df072c653c (patch) | |
tree | 2bfb3a10247a77a18deeb83f4f2387c9e76da197 /tools/testing/selftests/bpf/prog_tests/autoload.c | |
parent | 87c1696655787895689618c8b63c5efe66b8f2ab (diff) |
io_uring: fix race between poll completion and cancel_hash insertion
If poll arming and poll completion runs in parallel, there maybe races.
For instance, run io_poll_add in iowq and io_poll_task_func in original
context, then:
iowq original context
io_poll_add
vfs_poll
(interruption happens
tw queued to original
context) io_poll_task_func
generate cqe
del from cancel_hash[]
if !poll.done
insert to cancel_hash[]
The entry left in cancel_hash[], similar case for fast poll.
Fix it by set poll.done = true when del from cancel_hash[].
Fixes: 5082620fb2ca ("io_uring: terminate multishot poll for CQ ring overflow")
Signed-off-by: Hao Xu <haoxu@linux.alibaba.com>
Link: https://lore.kernel.org/r/20210922101238.7177-2-haoxu@linux.alibaba.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'tools/testing/selftests/bpf/prog_tests/autoload.c')
0 files changed, 0 insertions, 0 deletions