diff options
| author | Damien Le Moal <dlemoal@kernel.org> | 2023-05-29 16:32:37 +0900 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2023-05-29 08:40:32 -0600 |
| commit | 47fe1c3064c6bc1bfa3c032ff78e603e5dd6e5bc (patch) | |
| tree | 534c6f4fdce87b6299da2cc471546f255caaa083 /tools/testing/selftests/bpf/prog_tests/autoload.c | |
| parent | f270f8582353b70b8c6626252c8de3328ab45097 (diff) | |
block: fix revalidate performance regression
The scsi driver function sd_read_block_characteristics() always calls
disk_set_zoned() to a disk zoned model correctly, in case the device
model changed. This is done even for regular disks to set the zoned
model to BLK_ZONED_NONE and free any zone related resources if the drive
previously was zoned.
This behavior significantly impact the time it takes to revalidate disks
on a large system as the call to disk_clear_zone_settings() done from
disk_set_zoned() for the BLK_ZONED_NONE case results in the device
request queued to be frozen, even if there are no zone resources to
free.
Avoid this overhead for non-zoned devices by not calling
disk_clear_zone_settings() in disk_set_zoned() if the device model
was already set to BLK_ZONED_NONE, which is always the case for regular
devices.
Reported by: Brian Bunker <brian@purestorage.com>
Fixes: 508aebb80527 ("block: introduce blk_queue_clear_zone_settings()")
Cc: stable@vger.kernel.org
Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20230529073237.1339862-1-dlemoal@kernel.org
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'tools/testing/selftests/bpf/prog_tests/autoload.c')
0 files changed, 0 insertions, 0 deletions