aboutsummaryrefslogtreecommitdiff
path: root/tools/perf
diff options
context:
space:
mode:
authorPrarit Bhargava <[email protected]>2017-03-14 07:36:02 -0400
committerHerbert Xu <[email protected]>2017-03-16 17:43:11 +0800
commit8c75704ebcac2ffa31ee7bcc359baf701b52bf00 (patch)
treef114d4cd11eacd4426d46398589d5a5352dc5142 /tools/perf
parent69db7009318758769d625b023402161c750f7876 (diff)
hwrng: geode - Revert managed API changes
After commit e9afc746299d ("hwrng: geode - Use linux/io.h instead of asm/io.h") the geode-rng driver uses devres with pci_dev->dev to keep track of resources, but does not actually register a PCI driver. This results in the following issues: 1. The driver leaks memory because the driver does not attach to a device. The driver only uses the PCI device as a reference. devm_*() functions will release resources on driver detach, which the geode-rng driver will never do. As a result, 2. The driver cannot be reloaded because there is always a use of the ioport and region after the first load of the driver. Revert the changes made by e9afc746299d ("hwrng: geode - Use linux/io.h instead of asm/io.h"). Cc: <[email protected]> Signed-off-by: Prarit Bhargava <[email protected]> Fixes: 6e9b5e76882c ("hwrng: geode - Migrate to managed API") Cc: Matt Mackall <[email protected]> Cc: Corentin LABBE <[email protected]> Cc: PrasannaKumar Muralidharan <[email protected]> Cc: Wei Yongjun <[email protected]> Cc: [email protected] Cc: [email protected] Signed-off-by: Herbert Xu <[email protected]>
Diffstat (limited to 'tools/perf')
0 files changed, 0 insertions, 0 deletions