aboutsummaryrefslogtreecommitdiff
path: root/tools/perf/util/trace-event-scripting.c
diff options
context:
space:
mode:
authorPeter Zijlstra <[email protected]>2010-06-04 15:18:01 +0200
committerIngo Molnar <[email protected]>2010-06-08 18:43:00 +0200
commitf6ab91add6355e231e1c47897027b2a6ee4fa268 (patch)
tree74dffdf3b78c290d38a78b73788dce64e4c1e857 /tools/perf/util/trace-event-scripting.c
parent58cc1a9e3b11a84e66c4d3a4cc9073f2cb0ecabb (diff)
perf: Fix signed comparison in perf_adjust_period()
Frederic reported that frequency driven swevents didn't work properly and even caused a division-by-zero error. It turns out there are two bugs, the division-by-zero comes from a failure to deal with that in perf_calculate_period(). The other was more interesting and turned out to be a wrong comparison in perf_adjust_period(). The comparison was between an s64 and u64 and got implicitly converted to an unsigned comparison. The problem is that period_left is typically < 0, so it ended up being always true. Cure this by making the local period variables s64. Reported-by: Frederic Weisbecker <[email protected]> Tested-by: Frederic Weisbecker <[email protected]> Signed-off-by: Peter Zijlstra <[email protected]> Cc: <[email protected]> LKML-Reference: <new-submission> Signed-off-by: Ingo Molnar <[email protected]>
Diffstat (limited to 'tools/perf/util/trace-event-scripting.c')
0 files changed, 0 insertions, 0 deletions