diff options
author | Tony Lindgren <[email protected]> | 2018-12-04 13:52:49 -0800 |
---|---|---|
committer | Dmitry Torokhov <[email protected]> | 2018-12-08 21:48:48 -0800 |
commit | e2ca26ec4f01486661b55b03597c13e2b9c18b73 (patch) | |
tree | ff14d8fd8a4b993b12086b11c0cb202c125b744a /tools/perf/util/trace-event-scripting.c | |
parent | 6c3516fed7b61a3527459ccfa67fab130d910610 (diff) |
Input: omap-keypad - fix idle configuration to not block SoC idle states
With PM enabled, I noticed that pressing a key on the droid4 keyboard will
block deeper idle states for the SoC. Let's fix this by using IRQF_ONESHOT
and stop constantly toggling the device OMAP4_KBD_IRQENABLE register as
suggested by Dmitry Torokhov <[email protected]>.
From the hardware point of view, looks like we need to manage the registers
for OMAP4_KBD_IRQENABLE and OMAP4_KBD_WAKEUPENABLE together to avoid
blocking deeper SoC idle states. And with toggling of OMAP4_KBD_IRQENABLE
register now gone with IRQF_ONESHOT, also the SoC idle state problem is
gone during runtime. We still also need to clear OMAP4_KBD_WAKEUPENABLE in
omap4_keypad_close() though to pair it with omap4_keypad_open() to prevent
blocking deeper SoC idle states after rmmod omap4-keypad.
Reported-by: Pavel Machek <[email protected]>
Signed-off-by: Tony Lindgren <[email protected]>
Signed-off-by: Dmitry Torokhov <[email protected]>
Diffstat (limited to 'tools/perf/util/trace-event-scripting.c')
0 files changed, 0 insertions, 0 deletions