aboutsummaryrefslogtreecommitdiff
path: root/tools/perf/util/trace-event-scripting.c
diff options
context:
space:
mode:
authorQiuxu Zhuo <[email protected]>2018-09-07 16:08:27 -0700
committerBorislav Petkov <[email protected]>2018-09-11 10:59:21 +0200
commitdcc960b225ceb2bd66c45e0845d03e577f7010f9 (patch)
tree8636004f069621da1ef8bdc89001ce31d7732ab6 /tools/perf/util/trace-event-scripting.c
parent528d132c86a1f4be68e431edb247dae58f278160 (diff)
EDAC, sb_edac: Return early on ADDRV bit and address type test
Users of the mce_register_decode_chain() are called for every logged error. EDAC drivers should check: 1) Is this a memory error? [bit 7 in status register] 2) Is there a valid address? [bit 58 in status register] 3) Is the address a system address? [bitfield 8:6 in misc register] The sb_edac driver performed test "1" twice. Waited far too long to perform check "2". Didn't do check "3" at all. Fix it by moving the test for valid address from sbridge_mce_output_error() into sbridge_mce_check_error() and add a test for the type immediately after. Delete the redundant check for the type of the error from sbridge_mce_output_error(). Signed-off-by: Qiuxu Zhuo <[email protected]> Cc: Aristeu Rozanski <[email protected]> Cc: Mauro Carvalho Chehab <[email protected]> Cc: Qiuxu Zhuo <[email protected]> Cc: linux-edac <[email protected]> Link: http://lkml.kernel.org/r/[email protected] [ Re-word commit message. ] Signed-off-by: Tony Luck <[email protected]> Signed-off-by: Borislav Petkov <[email protected]>
Diffstat (limited to 'tools/perf/util/trace-event-scripting.c')
0 files changed, 0 insertions, 0 deletions