diff options
author | Herton Ronaldo Krzesinski <[email protected]> | 2012-08-27 20:56:51 -0300 |
---|---|---|
committer | Jens Axboe <[email protected]> | 2012-10-30 08:34:24 +0100 |
commit | b54e1f88897bcacc2cd359f48ea3b39eaf55f084 (patch) | |
tree | 664c10b93917479b78e11d8e53d77f7a5e9cc440 /tools/perf/util/trace-event-scripting.c | |
parent | 2911758f14e36a7cd5c7367f951dcb8817552f71 (diff) |
floppy: don't call alloc_ordered_workqueue inside the alloc_disk loop
Since commit 070ad7e ("floppy: convert to delayed work and single-thread
wq"), we end up calling alloc_ordered_workqueue multiple times inside
the loop, which shouldn't be intended. Besides the leak, other side
effect in the current code is if blk_init_queue fails, we would end up
calling unregister_blkdev even if we didn't call yet register_blkdev.
Just moved the allocation of floppy_wq before the loop, and adjusted the
code accordingly.
Cc: [email protected] # 3.5+
Acked-by: Vivek Goyal <[email protected]>
Reviewed-by: Ben Hutchings <[email protected]>
Signed-off-by: Herton Ronaldo Krzesinski <[email protected]>
Signed-off-by: Jiri Kosina <[email protected]>
Signed-off-by: Jens Axboe <[email protected]>
Diffstat (limited to 'tools/perf/util/trace-event-scripting.c')
0 files changed, 0 insertions, 0 deletions