diff options
author | Mateusz Guzik <[email protected]> | 2014-06-14 15:00:09 +0200 |
---|---|---|
committer | Ingo Molnar <[email protected]> | 2014-07-16 13:36:07 +0200 |
commit | b0ab99e7736af88b8ac1b7ae50ea287fffa2badc (patch) | |
tree | aee41b518d3cef411ebdf4bf385d28858a5fa759 /tools/perf/util/trace-event-scripting.c | |
parent | b6220ad66bcd4a50737eb3c08e9466aa44f3bc98 (diff) |
sched: Fix possible divide by zero in avg_atom() calculation
proc_sched_show_task() does:
if (nr_switches)
do_div(avg_atom, nr_switches);
nr_switches is unsigned long and do_div truncates it to 32 bits, which
means it can test non-zero on e.g. x86-64 and be truncated to zero for
division.
Fix the problem by using div64_ul() instead.
As a side effect calculations of avg_atom for big nr_switches are now correct.
Signed-off-by: Mateusz Guzik <[email protected]>
Signed-off-by: Peter Zijlstra <[email protected]>
Cc: [email protected]
Cc: Linus Torvalds <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Ingo Molnar <[email protected]>
Diffstat (limited to 'tools/perf/util/trace-event-scripting.c')
0 files changed, 0 insertions, 0 deletions