diff options
author | Frederic Weisbecker <[email protected]> | 2010-04-08 14:05:50 +0200 |
---|---|---|
committer | Frederic Weisbecker <[email protected]> | 2010-04-08 19:03:28 +0200 |
commit | ab285f2b5290d92b7ec1a6f9aad54308dadf6157 (patch) | |
tree | 70ffdac1d267401330b487bc6f502a9206a4ae6b /tools/perf/util/trace-event-scripting.c | |
parent | 134fbadf028a5977a1b06b0253d3ee33e6f0c642 (diff) |
perf: Fix unsafe frame rewinding with hot regs fetching
When we fetch the hot regs and rewind to the nth caller, it
might happen that we dereference a frame pointer outside the
kernel stack boundaries, like in this example:
perf_trace_sched_switch+0xd5/0x120
schedule+0x6b5/0x860
retint_careful+0xd/0x21
Since we directly dereference a userspace frame pointer here while
rewinding behind retint_careful, this may end up in a crash.
Fix this by simply using probe_kernel_address() when we rewind the
frame pointer.
This issue will have a much more proper fix in the next version of the
perf_arch_fetch_caller_regs() API that will only need to rewind to the
first caller.
Reported-by: Eric Dumazet <[email protected]>
Signed-off-by: Frederic Weisbecker <[email protected]>
Tested-by: Eric Dumazet <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Arnaldo Carvalho de Melo <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: David Miller <[email protected]>
Cc: Archs <[email protected]>
Diffstat (limited to 'tools/perf/util/trace-event-scripting.c')
0 files changed, 0 insertions, 0 deletions