diff options
author | Chris Wright <[email protected]> | 2011-02-14 17:21:49 -0800 |
---|---|---|
committer | James Morris <[email protected]> | 2011-02-15 19:06:31 +1100 |
commit | a628e7b87e100befac9702aa0c3b9848a7685e49 (patch) | |
tree | 3771e7bc343f9ce6cd336f513d7c177845d8f92b /tools/perf/util/trace-event-scripting.c | |
parent | 795abaf1e4e188c4171e3cd3dbb11a9fcacaf505 (diff) |
pci: use security_capable() when checking capablities during config space read
This reintroduces commit 47970b1b which was subsequently reverted
as f00eaeea. The original change was broken and caused X startup
failures and generally made privileged processes incapable of reading
device dependent config space. The normal capable() interface returns
true on success, but the LSM interface returns 0 on success. This thinko
is now fixed in this patch, and has been confirmed to work properly.
So, once again...Eric Paris noted that commit de139a3 ("pci: check caps
from sysfs file open to read device dependent config space") caused the
capability check to bypass security modules and potentially auditing.
Rectify this by calling security_capable() when checking the open file's
capabilities for config space reads.
Reported-by: Eric Paris <[email protected]>
Tested-by: Dave Young <[email protected]>
Acked-by: James Morris <[email protected]>
Cc: Dave Airlie <[email protected]>
Cc: Alex Riesen <[email protected]>
Cc: Sedat Dilek <[email protected]>
Cc: Linus Torvalds <[email protected]>
Signed-off-by: Chris Wright <[email protected]>
Signed-off-by: James Morris <[email protected]>
Diffstat (limited to 'tools/perf/util/trace-event-scripting.c')
0 files changed, 0 insertions, 0 deletions