diff options
author | Peter Zijlstra <[email protected]> | 2020-10-28 09:11:23 +0100 |
---|---|---|
committer | Arnaldo Carvalho de Melo <[email protected]> | 2020-11-03 08:32:15 -0300 |
commit | 9ae1e990f1ab522b98baefbfebf3cbac1a2cfac2 (patch) | |
tree | 0e3940748249c2e01afb9c8ab471973f7a553dd5 /tools/perf/util/trace-event-scripting.c | |
parent | 0dfbe4c646bf06a85c3d70572a8b8aa6ebffe3d5 (diff) |
perf tools: Remove broken __no_tail_call attribute
The GCC specific __attribute__((optimize)) attribute does not what is
commonly expected and is explicitly recommended against using in
production code by the GCC people.
Unlike what is often expected, it doesn't add to the optimization flags,
but it fully replaces them, loosing any and all optimization flags
provided by the compiler commandline.
The only guaranteed upon means of inhibiting tail-calls is by placing a
volatile asm with side-effects after the call such that the tail-call simply
cannot be done.
Given the original commit wasn't specific on which calls were the problem, this
removal might re-introduce the problem, which can then be re-analyzed and cured
properly.
Signed-off-by: Peter Zijlstra <[email protected]>
Acked-by: Ard Biesheuvel <[email protected]>
Acked-by: Miguel Ojeda <[email protected]>
Cc: Alexei Starovoitov <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Cc: Arvind Sankar <[email protected]>
Cc: Daniel Borkmann <[email protected]>
Cc: Geert Uytterhoeven <[email protected]>
Cc: Ian Rogers <[email protected]>
Cc: Josh Poimboeuf <[email protected]>
Cc: Kees Kook <[email protected]>
Cc: Martin Liška <[email protected]>
Cc: Nick Desaulniers <[email protected]>
Cc: Randy Dunlap <[email protected]>
Cc: Thomas Gleixner <[email protected]>
Link: http://lore.kernel.org/lkml/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
Diffstat (limited to 'tools/perf/util/trace-event-scripting.c')
0 files changed, 0 insertions, 0 deletions