diff options
author | Yinghai Lu <[email protected]> | 2012-09-19 11:54:15 -0700 |
---|---|---|
committer | Bjorn Helgaas <[email protected]> | 2012-09-24 13:35:00 -0600 |
commit | 84544a1dea61879edebceddb7a76d5737409f8c8 (patch) | |
tree | 77aa802b5492a072109b74e41fac1a8f36a19d54 /tools/perf/util/trace-event-scripting.c | |
parent | da104919059bd89dc77a77d74b0fb289384ce9b1 (diff) |
PCI: Fix default vga ref_count
when __ARCH_HAS_VGA_DEFAULT_DEVICE is not defined, aka EFIFB is not used,
for static path, vga_default setting is through vga_arbiter_add_pci_device.
and later x86 pci_fixup_video, will skip setting again.
- subsys_initcall(vga_arb_device_init) come first to call
vga_arbiter_add_pci_device. It will call pci_get_dev to hold one reference.
for hotplug add path, even vga_arbiter_add_pci_device is called via
notifier, but it will check VGA_RSRC_LEGACY_MASK that is not set for
hotplug path. So x86 pci_fixup_video will take over to call
vga_set_default_device(). It will not hold one refrence.
Later for hotplug remove path, vga_arbiter_del_pci_device that does not
check VGA_RSRC_LEGACY_MASK will call put_device and it will cause ref_count
to decrease extra. that will have that pci device get deleted early
wrongly.
Need to make get/put balance for both cases.
Signed-off-by: Yinghai Lu <[email protected]>
Signed-off-by: Bjorn Helgaas <[email protected]>
Cc: [email protected]
Cc: Dave Airlie <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: Julia Lawall <[email protected]>
Cc: Matthew Garrett <[email protected]>
Diffstat (limited to 'tools/perf/util/trace-event-scripting.c')
0 files changed, 0 insertions, 0 deletions