diff options
author | Quentin Perret <[email protected]> | 2021-04-30 15:14:12 +0000 |
---|---|---|
committer | Peter Zijlstra <[email protected]> | 2021-05-06 15:33:26 +0200 |
commit | 6d2f8909a5fabb73fe2a63918117943986c39b6c (patch) | |
tree | 7046c225d90183e5bd49a00a15a95cf703c37716 /tools/perf/util/trace-event-scripting.c | |
parent | d583d360a620e6229422b3455d0be082b8255f5e (diff) |
sched: Fix out-of-bound access in uclamp
Util-clamp places tasks in different buckets based on their clamp values
for performance reasons. However, the size of buckets is currently
computed using a rounding division, which can lead to an off-by-one
error in some configurations.
For instance, with 20 buckets, the bucket size will be 1024/20=51. A
task with a clamp of 1024 will be mapped to bucket id 1024/51=20. Sadly,
correct indexes are in range [0,19], hence leading to an out of bound
memory access.
Clamp the bucket id to fix the issue.
Fixes: 69842cba9ace ("sched/uclamp: Add CPU's clamp buckets refcounting")
Suggested-by: Qais Yousef <[email protected]>
Signed-off-by: Quentin Perret <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Reviewed-by: Vincent Guittot <[email protected]>
Reviewed-by: Dietmar Eggemann <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
Diffstat (limited to 'tools/perf/util/trace-event-scripting.c')
0 files changed, 0 insertions, 0 deletions