diff options
author | Yoshihiro YUNOMAE <[email protected]> | 2014-02-20 17:44:31 +0900 |
---|---|---|
committer | Steven Rostedt <[email protected]> | 2014-05-29 23:08:07 -0400 |
commit | 42584c81c5adc1737a6fe0687facc5e62a5dc8c1 (patch) | |
tree | 25dbedd93aa7618d436495cce800627cf1761d8e /tools/perf/util/trace-event-scripting.c | |
parent | 81dc9f0ef21e40114cc895894c7acf3055f6d1fb (diff) |
tracing: Have saved_cmdlines use the seq_read infrastructure
Current tracing_saved_cmdlines_read() implementation is naive; It allocates
a large buffer, constructs output data to that buffer for each read
operation, and then copies a portion of the buffer to the user space
buffer. This has several issues such as slow memory allocation, high
CPU usage, and even corruption of the output data.
The seq_read infrastructure is made to handle this type of work.
By converting it to use seq_read() the code becomes smaller, simplified,
as well as correct.
Link: http://lkml.kernel.org/p/20140220084431.3839.51793.stgit@yunodevel
Signed-off-by: Hidehiro Kawai <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: Masami Hiramatsu <[email protected]>
Signed-off-by: Yoshihiro YUNOMAE <[email protected]>
Cc: Frederic Weisbecker <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: [email protected]
Signed-off-by: Steven Rostedt <[email protected]>
Diffstat (limited to 'tools/perf/util/trace-event-scripting.c')
0 files changed, 0 insertions, 0 deletions