diff options
author | Mathias Krause <[email protected]> | 2014-08-27 18:41:19 +0200 |
---|---|---|
committer | Jani Nikula <[email protected]> | 2014-08-28 09:54:27 +0300 |
commit | bbe1c2740d3a25aa1dbe5d842d2ff09cddcdde0a (patch) | |
tree | 3efb4bf01eada95465814178774a336c5d8dc711 /tools/perf/util/scripting-engines/trace-event-python.c | |
parent | 813008cd3e93ea8a571b2b7d5b9360a3105b50f7 (diff) |
drm/i915: Remove bogus __init annotation from DMI callbacks
The __init annotations for the DMI callback functions are wrong as this
code can be called even after the module has been initialized, e.g. like
this:
# echo 1 > /sys/bus/pci/devices/0000:00:02.0/remove
# modprobe i915
# echo 1 > /sys/bus/pci/rescan
The first command will remove the PCI device from the kernel's device
list so the second command won't see it right away. But as it registers
a PCI driver it'll see it on the third command. If the system happens to
match one of the DMI table entries we'll try to call a function in long
released memory and generate an Oops, at best.
Fix this by removing the bogus annotation.
Modpost should have caught that one but it ignores section reference
mismatches from the .rodata section. :/
Fixes: 25e341cfc33d ("drm/i915: quirk away broken OpRegion VBT")
Fixes: 8ca4013d702d ("CHROMIUM: i915: Add DMI override to skip CRT...")
Fixes: 425d244c8670 ("drm/i915: ignore LVDS on intel graphics systems...")
Signed-off-by: Mathias Krause <[email protected]>
Cc: Daniel Vetter <[email protected]>
Cc: Duncan Laurie <[email protected]>
Cc: Jarod Wilson <[email protected]>
Cc: Rusty Russell <[email protected]> # Can modpost be fixed?
Cc: [email protected]
Signed-off-by: Jani Nikula <[email protected]>
Diffstat (limited to 'tools/perf/util/scripting-engines/trace-event-python.c')
0 files changed, 0 insertions, 0 deletions