diff options
author | Oleg Nesterov <[email protected]> | 2012-07-29 20:22:20 +0200 |
---|---|---|
committer | Ingo Molnar <[email protected]> | 2012-07-30 11:27:20 +0200 |
commit | 9f92448ceeea5326db7d114005a7e7ac03904edf (patch) | |
tree | 42bd61d15b445d8677806adeadae99767094386c /tools/perf/util/scripting-engines/trace-event-python.c | |
parent | 089ba999dc881a7549d97c55ac9e0052d061867d (diff) |
uprobes: Clean up and document write_opcode()->lock_page(old_page)
The comment above write_opcode()->lock_page(old_page) tells
about the race with do_wp_page(). I don't really understand
which exactly race it means, but afaics this lock_page() was not
enough to close all races with do_wp_page().
Anyway, since:
77fc4af1b59d uprobes: Change register_for_each_vma() to take mm->mmap_sem for writing
this code is always called with ->mmap_sem held for writing,
so we can forget about do_wp_page().
However, we can't simply remove this lock_page(), and the only
(afaics) reason is __replace_page()->try_to_free_swap().
Nothing in write_opcode() needs it, move it into
__replace_page() and fix the comment.
Signed-off-by: Oleg Nesterov <[email protected]>
Acked-by: Srikar Dronamraju <srikar.vnet.ibm.com>
Cc: Anton Arapov <[email protected]>
Cc: Srikar Dronamraju <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Ingo Molnar <[email protected]>
Diffstat (limited to 'tools/perf/util/scripting-engines/trace-event-python.c')
0 files changed, 0 insertions, 0 deletions