diff options
author | Namhyung Kim <[email protected]> | 2013-04-11 15:55:01 +0900 |
---|---|---|
committer | Steven Rostedt <[email protected]> | 2013-04-12 14:43:34 -0400 |
commit | 6a76f8c0ab19f215af2a3442870eeb5f0e81998d (patch) | |
tree | 551f1c13779323e06b8ef906192ba7a5d87aa7b6 /tools/perf/scripts | |
parent | 83e03b3fe4daffdebbb42151d5410d730ae50bd1 (diff) |
tracing: Fix possible NULL pointer dereferences
Currently set_ftrace_pid and set_graph_function files use seq_lseek
for their fops. However seq_open() is called only for FMODE_READ in
the fops->open() so that if an user tries to seek one of those file
when she open it for writing, it sees NULL seq_file and then panic.
It can be easily reproduced with following command:
$ cd /sys/kernel/debug/tracing
$ echo 1234 | sudo tee -a set_ftrace_pid
In this example, GNU coreutils' tee opens the file with fopen(, "a")
and then the fopen() internally calls lseek().
Link: http://lkml.kernel.org/r/[email protected]
Cc: Frederic Weisbecker <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Namhyung Kim <[email protected]>
Cc: [email protected]
Signed-off-by: Namhyung Kim <[email protected]>
Signed-off-by: Steven Rostedt <[email protected]>
Diffstat (limited to 'tools/perf/scripts')
0 files changed, 0 insertions, 0 deletions