diff options
author | Namhyung Kim <[email protected]> | 2012-12-27 18:11:46 +0900 |
---|---|---|
committer | Arnaldo Carvalho de Melo <[email protected]> | 2013-01-24 16:40:26 -0300 |
commit | fc5871ed0dcf8c76dd1b3b36ff0f70112d2f0e74 (patch) | |
tree | c0ebaf638bb6d51afc2e24dd6a4c3d35fe64a54a /tools/perf/scripts/python | |
parent | 6f38cf25a6af5b21da1d52a94d9f56f5af2a215b (diff) |
perf sort: Separate out branch stack specific sort keys
Current perf report gets segmentation fault when a branch stack specific
sort key is provided by --sort option to a perf.data file which contains
no branch infomation. It's because those sort keys reference branch
info of a hist entry unconditionally. Maybe we can change it checks
whether such branch info is valid or not. But if the branch stacks are
not recorded, it'd be nop. Thus it'd be better to make those keys are
unselectable.
This patch separates those keys to a different dimension array, so that
if user passes such a key to a file which has no branch stack will get
following message rather than a segfault.
Error: Invalid --sort key: `symbol_from'
Signed-off-by: Namhyung Kim <[email protected]>
Reported-by: Stefan Beller <[email protected]>
Acked-by: Jiri Olsa <[email protected]>
Cc: David Ahern <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: Jiri Olsa <[email protected]>
Cc: Paul Mackerras <[email protected]>
Cc: Peter Zijlstra <[email protected]>
Cc: Stephane Eranian <[email protected]>
Link: http://lkml.kernel.org/r/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python')
0 files changed, 0 insertions, 0 deletions