diff options
| author | Michael Buesch <[email protected]> | 2009-01-06 14:43:14 -0800 |
|---|---|---|
| committer | Linus Torvalds <[email protected]> | 2009-01-06 15:59:31 -0800 |
| commit | f59abb161c955b68fd3d473368420c5919733e09 (patch) | |
| tree | b316a7acdbc2e2eb819614e61644249937903f47 /tools/perf/scripts/python | |
| parent | 50682bb4de35544466c264c017030de826614367 (diff) | |
parport: ieee1284: use del_timer_sync() in parport_wait_event()
Use del_timer_sync() instead of del_timer() to make sure the timer won't
be running when we return from parport_wait_event(), because this would
crash due to destruction of timer_list.
This is untested and just based on a code review. Just think about the
following sequence of events:
- add_timer()
- down_interruptible() is interrupted by a signal.
- we enter the timer callback handler on another CPU.
- del_timer(), but the timer callback is still running.
- eturn from parport_wait_even, which destroys the automatic variable
"timer" while the callback is running on another CPU.
[[email protected]: coding-style fixes]
Signed-off-by: Michael Buesch <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python')
0 files changed, 0 insertions, 0 deletions