diff options
author | Chris Wilson <[email protected]> | 2020-09-28 23:15:09 +0100 |
---|---|---|
committer | Rodrigo Vivi <[email protected]> | 2020-09-30 14:24:48 -0400 |
commit | ca65fc0d8e01dca8fc82f0ccf433725469256c71 (patch) | |
tree | 538fce4f5c593685aedf6b3dded266706f60e86c /tools/perf/scripts/python | |
parent | 7d442ea7c504adcc9798b07cd8f6a0d235fca2da (diff) |
drm/i915/gt: Always send a pulse down the engine after disabling heartbeat
Currently, we check we can send a pulse prior to disabling the
heartbeat to verify that we can change the heartbeat, but since we may
re-evaluate execution upon changing the heartbeat interval we need another
pulse afterwards to refresh execution.
v2: Tvrtko asked if we could reduce the double pulse to a single, which
opened up a discussion of how we should handle the pulse-error after
attempting to change the property, and the desire to serialise
adjustment of the property with its validating pulse, and unwind upon
failure.
Fixes: 9a40bddd47ca ("drm/i915/gt: Expose heartbeat interval via sysfs")
Signed-off-by: Chris Wilson <[email protected]>
Cc: Joonas Lahtinen <[email protected]>
Cc: Tvrtko Ursulin <[email protected]>
Cc: <[email protected]> # v5.7+
Reviewed-by: Tvrtko Ursulin <[email protected]>
Acked-by: Joonas Lahtinen <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
(cherry picked from commit 3dd66a94de59d7792e7917eb3075342e70f06f44)
Signed-off-by: Rodrigo Vivi <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python')
0 files changed, 0 insertions, 0 deletions