diff options
| author | Arend van Spriel <[email protected]> | 2024-07-27 20:56:17 +0200 |
|---|---|---|
| committer | Kalle Valo <[email protected]> | 2024-08-04 12:10:00 +0300 |
| commit | c6002b6c05f3edfa12fd25990cc637281f200442 (patch) | |
| tree | 15ed28fe185393683dc0537b9ed5562263eb2bc5 /tools/perf/scripts/python | |
| parent | 16b31ecb802946f1855259a2006c32c8d340ea5c (diff) | |
wifi: brcmfmac: introducing fwil query functions
When the firmware interface layer was refactored it provided various
"get" and "set" functions. For the "get" in some cases a parameter
needed to be passed down to firmware as a key indicating what to
"get" turning the output parameter of the "get" function into an
input parameter as well. To accommodate this the "get" function blindly
copies the parameter which in some places resulted in an uninitialized
warnings from the compiler. These have been fixed by initializing the
input parameter in the past. Recently another batch of similar fixes
were submitted to address clang static checker warnings [1].
Proposing another solution by introducing a "query" variant which is used
when the (input) parameter is needed by firmware. The "get" variant will
only fill the (output) parameter with the result received from firmware
taking care of proper endianess conversion.
[1] https://lore.kernel.org/all/[email protected]/
Fixes: 81f5dcb80830 ("brcmfmac: refactor firmware interface layer.")
Reported-by: Su Hui <[email protected]>
Signed-off-by: Arend van Spriel <[email protected]>
Signed-off-by: Kalle Valo <[email protected]>
Link: https://patch.msgid.link/[email protected]
Diffstat (limited to 'tools/perf/scripts/python')
0 files changed, 0 insertions, 0 deletions