diff options
| author | Tom Rix <[email protected]> | 2020-08-05 07:52:08 -0700 |
|---|---|---|
| committer | Bartlomiej Zolnierkiewicz <[email protected]> | 2020-09-08 13:33:06 +0200 |
| commit | ad6f93e9cd56f0b10e9b22e3e137d17a1a035242 (patch) | |
| tree | bc2bace432bc3bdc869941658f54e87f0fea63ea /tools/perf/scripts/python | |
| parent | fe2ab107536d808ad0c8ddce3e35b048dc5acb0f (diff) | |
video: fbdev: sis: fix null ptr dereference
Clang static analysis reports this representative error
init.c:2501:18: warning: Array access (from variable 'queuedata') results
in a null pointer dereference
templ |= ((queuedata[i] & 0xc0) << 3);
This is the problem block of code
if(ModeNo > 0x13) {
...
if(SiS_Pr->ChipType == SIS_730) {
queuedata = &FQBQData730[0];
} else {
queuedata = &FQBQData[0];
}
} else {
}
queuedata is not set in the else block
Reviewing the old code, the arrays FQBQData730 and FQBQData were
used directly.
So hoist the setting of queuedata out of the if-else block.
Fixes: 544393fe584d ("[PATCH] sisfb update")
Signed-off-by: Tom Rix <[email protected]>
Cc: Thomas Winischhofer <[email protected]>
Cc: Andrew Morton <[email protected]>
Signed-off-by: Bartlomiej Zolnierkiewicz <[email protected]>
Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
Diffstat (limited to 'tools/perf/scripts/python')
0 files changed, 0 insertions, 0 deletions