aboutsummaryrefslogtreecommitdiff
path: root/tools/perf/scripts/python
diff options
context:
space:
mode:
authorMinchan Kim <[email protected]>2011-03-22 16:30:53 -0700
committerLinus Torvalds <[email protected]>2011-03-22 17:44:02 -0700
commit97cecb5a254fec22d28ef32235d888bfbfd7c783 (patch)
tree186c6bb9c1f999f807e2ec68dc6a0cf16c9d0d73 /tools/perf/scripts/python
parentef6a3c63112e865d632ff7c478ba7c7160cad0d1 (diff)
mm: introduce delete_from_page_cache()
Presently we increase the page refcount in add_to_page_cache() but don't decrease it in remove_from_page_cache(). Such asymmetry adds confusion, requiring that callers notice it and a comment explaining why they release a page reference. It's not a good API. A long time ago, Hugh tried it (http://lkml.org/lkml/2004/10/24/140) but gave up because reiser4's drop_page() had to unlock the page between removing it from page cache and doing the page_cache_release(). But now the situation is changed. I think at least things in current mainline don't have any obstacles. The problem is for out-of-mainline filesystems - if they have done such things as reiser4, this patch could be a problem but they will discover this at compile time since we remove remove_from_page_cache(). This patch: This function works as just wrapper remove_from_page_cache(). The difference is that it decreases page references in itself. So caller have to make sure it has a page reference before calling. This patch is ready for removing remove_from_page_cache(). Signed-off-by: Minchan Kim <[email protected]> Cc: Christoph Hellwig <[email protected]> Acked-by: Hugh Dickins <[email protected]> Acked-by: Mel Gorman <[email protected]> Reviewed-by: KAMEZAWA Hiroyuki <[email protected]> Reviewed-by: Johannes Weiner <[email protected]> Reviewed-by: KOSAKI Motohiro <[email protected]> Cc: Edward Shishkin <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python')
0 files changed, 0 insertions, 0 deletions