diff options
| author | Yu Ma <[email protected]> | 2023-07-12 10:57:39 -0400 |
|---|---|---|
| committer | Andrew Morton <[email protected]> | 2023-08-18 10:12:26 -0700 |
| commit | 6852c46c783d20a4c0153d14d2990040e5e6e47e (patch) | |
| tree | 4716a63b046da2fbf02f60ee55111cc95e6a378d /tools/perf/scripts/python | |
| parent | 73e791d73877e90444afb6036d86ea37fd78584f (diff) | |
mm/mmap: move vma operations to mm_struct out of the critical section of file mapping lock
UnixBench/Execl represents a class of workload where bash scripts are
spawned frequently to do some short jobs. When running multiple parallel
tasks, hot osq_lock is observed from do_mmap and exit_mmap. Both of them
come from load_elf_binary through the call chain
"execl->do_execveat_common->bprm_execve->load_elf_binary".
In do_mmap,it will call mmap_region to create vma node, initialize it and
insert it to vma maintain structure in mm_struct and i_mmap tree of the
mapping file, then increase map_count to record the number of vma nodes
used. The hot osq_lock is to protect operations on file's i_mmap tree.
For the mm_struct member change like vma insertion and map_count update,
they do not affect i_mmap tree. Move those operations out of the lock's
critical section, to reduce hold time on the lock.
With this change, on Intel Sapphire Rapids 112C/224T platform, based on
v6.0-rc6, the 160 parallel score improves by 12%. The patch has no
obvious performance gain on v6.5-rc1 due to regression of this benchmark
from this commit f1a7941243c102a44e8847e3b94ff4ff3ec56f25 (mm: convert
mm's rss stats into percpu_counter). Related discussion and conclusion
can be referred at the mail thread initiated by 0day as below: Link:
https://lore.kernel.org/linux-mm/[email protected]/
Link: https://lkml.kernel.org/r/[email protected]
Signed-off-by: Yu Ma <[email protected]>
Reviewed-by: Tim Chen <[email protected]>
Cc: Dan Williams <[email protected]>
Cc: Dave Hansen <[email protected]>
Cc: Kirill A . Shutemov <[email protected]>
Cc: Liam R. Howlett <[email protected]>
Cc: Shakeel Butt <[email protected]>
Cc: Zhu, Lipeng <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python')
0 files changed, 0 insertions, 0 deletions