diff options
| author | Oleg Nesterov <[email protected]> | 2009-09-23 15:56:48 -0700 |
|---|---|---|
| committer | Linus Torvalds <[email protected]> | 2009-09-24 07:21:00 -0700 |
| commit | 5c01ba49e6647d86bc7576105f82027200d1f303 (patch) | |
| tree | 700aa5dbda7c726e8b60803225587a1bc4fdbdb5 /tools/perf/scripts/python | |
| parent | b4fe51823d797d6959b2eee7868023e61606daa9 (diff) | |
do_wait-wakeup-optimization: fix child_wait_callback()->eligible_child() usage
child_wait_callback()->eligible_child() is not right, we can miss the
wakeup if the task was detached before __wake_up_parent() and the caller
of do_wait() didn't use __WALL.
Move ->wo_pid checks from eligible_child() to the new helper,
eligible_pid(), and change child_wait_callback() to use it instead of
eligible_child().
Note: actually I think it would be better to fix the __WCLONE check in
eligible_child(), it doesn't look exactly right. But it is not clear what
is the supposed behaviour, and any change is user-visible.
Reported-by: KAMEZAWA Hiroyuki <[email protected]>
Tested-by: KAMEZAWA Hiroyuki <[email protected]>
Signed-off-by: Oleg Nesterov <[email protected]>
Cc: Roland McGrath <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python')
0 files changed, 0 insertions, 0 deletions