diff options
author | Tejun Heo <[email protected]> | 2012-08-03 10:30:47 -0700 |
---|---|---|
committer | Tejun Heo <[email protected]> | 2012-08-13 16:27:37 -0700 |
commit | 41f63c5359d14ca995172b8f6eaffd93f60fec54 (patch) | |
tree | d3d93dfd25d2e29e8abeae934835f2266b018cb7 /tools/perf/scripts/python | |
parent | 8376fe22c7e79c7e90857d39f82aeae6cad6c4b8 (diff) |
workqueue: use mod_delayed_work() instead of cancel + queue
Convert delayed_work users doing cancel_delayed_work() followed by
queue_delayed_work() to mod_delayed_work().
Most conversions are straight-forward. Ones worth mentioning are,
* drivers/edac/edac_mc.c: edac_mc_workq_setup() converted to always
use mod_delayed_work() and cancel loop in
edac_mc_reset_delay_period() is dropped.
* drivers/platform/x86/thinkpad_acpi.c: No need to remember whether
watchdog is active or not. @fan_watchdog_active and related code
dropped.
* drivers/power/charger-manager.c: Seemingly a lot of
delayed_work_pending() abuse going on here.
[delayed_]work_pending() are unsynchronized and racy when used like
this. I converted one instance in fullbatt_handler(). Please
conver the rest so that it invokes workqueue APIs for the intended
target state rather than trying to game work item pending state
transitions. e.g. if timer should be modified - call
mod_delayed_work(), canceled - call cancel_delayed_work[_sync]().
* drivers/thermal/thermal_sys.c: thermal_zone_device_set_polling()
simplified. Note that round_jiffies() calls in this function are
meaningless. round_jiffies() work on absolute jiffies not delta
delay used by delayed_work.
v2: Tomi pointed out that __cancel_delayed_work() users can't be
safely converted to mod_delayed_work(). They could be calling it
from irq context and if that happens while delayed_work_timer_fn()
is running, it could deadlock. __cancel_delayed_work() users are
dropped.
Signed-off-by: Tejun Heo <[email protected]>
Acked-by: Henrique de Moraes Holschuh <[email protected]>
Acked-by: Dmitry Torokhov <[email protected]>
Acked-by: Anton Vorontsov <[email protected]>
Acked-by: David Howells <[email protected]>
Cc: Tomi Valkeinen <[email protected]>
Cc: Jens Axboe <[email protected]>
Cc: Jiri Kosina <[email protected]>
Cc: Doug Thompson <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Roland Dreier <[email protected]>
Cc: "John W. Linville" <[email protected]>
Cc: Zhang Rui <[email protected]>
Cc: Len Brown <[email protected]>
Cc: "J. Bruce Fields" <[email protected]>
Cc: Johannes Berg <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python')
0 files changed, 0 insertions, 0 deletions