diff options
| author | Chengming Zhou <[email protected]> | 2024-02-04 03:06:02 +0000 |
|---|---|---|
| committer | Andrew Morton <[email protected]> | 2024-02-22 10:24:54 -0800 |
| commit | 3b631bd06550040b37cd2ebb00e2374404db0360 (patch) | |
| tree | 835ea3da4b2e8ca21da8768090b88f22c2ec1eb4 /tools/perf/scripts/python | |
| parent | b49547ade38a63ff39c9fbc53fb38622cb63854a (diff) | |
mm/zswap: remove duplicate_entry debug value
cat /sys/kernel/debug/zswap/duplicate_entry
2086447
When testing, the duplicate_entry value is very high, but no warning
message in the kernel log. From the comment of duplicate_entry "Duplicate
store was encountered (rare)", it seems something goes wrong.
Actually it's incremented in the beginning of zswap_store(), which found
its zswap entry has already on the tree. And this is a normal case, since
the folio could leave zswap entry on the tree after swapin, later it's
dirtied and swapout/zswap_store again, found its original zswap entry.
So duplicate_entry should be only incremented in the real bug case, which
already have "WARN_ON(1)", it looks redundant to count bug case, so this
patch just remove it.
Link: https://lkml.kernel.org/r/20240201-b4-zswap-invalidate-entry-v2-4-99d4084260a0@bytedance.com
Signed-off-by: Chengming Zhou <[email protected]>
Acked-by: Johannes Weiner <[email protected]>
Reviewed-by: Nhat Pham <[email protected]>
Acked-by: Yosry Ahmed <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python')
0 files changed, 0 insertions, 0 deletions