diff options
| author | Kalesh Singh <[email protected]> | 2023-05-23 13:59:21 -0700 |
|---|---|---|
| committer | Andrew Morton <[email protected]> | 2023-06-09 16:25:46 -0700 |
| commit | 3af0191a594d5ca5d6d2e3602b5d4284c6835e77 (patch) | |
| tree | 53b368f7763895ae8914982efa4ec9796180bc6b /tools/perf/scripts/python | |
| parent | 06b27ce36a1a3dc5ea6f8314d0c7d1baa9f8ece7 (diff) | |
Multi-gen LRU: fix workingset accounting
On Android app cycle workloads, MGLRU showed a significant reduction in
workingset refaults although pgpgin/pswpin remained relatively unchanged.
This indicated MGLRU may be undercounting workingset refaults.
This has impact on userspace programs, like Android's LMKD, that monitor
workingset refault statistics to detect thrashing.
It was found that refaults were only accounted if the MGLRU shadow entry
was for a recently evicted folio. However, recently evicted folios should
be accounted as workingset activation, and refaults should be accounted
regardless of recency.
Fix MGLRU's workingset refault and activation accounting to more closely
match that of the conventional active/inactive LRU.
Link: https://lkml.kernel.org/r/[email protected]
Fixes: ac35a4902374 ("mm: multi-gen LRU: minimal implementation")
Signed-off-by: Kalesh Singh <[email protected]>
Reported-by: Charan Teja Kalla <[email protected]>
Acked-by: Yu Zhao <[email protected]>
Cc: Brian Geffon <[email protected]>
Cc: Jan Alexander Steffens (heftig) <[email protected]>
Cc: Oleksandr Natalenko <[email protected]>
Cc: Suren Baghdasaryan <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python')
0 files changed, 0 insertions, 0 deletions