diff options
| author | Akinobu Mita <[email protected]> | 2018-06-10 11:42:26 -0400 |
|---|---|---|
| committer | Mauro Carvalho Chehab <[email protected]> | 2018-06-28 09:22:57 -0400 |
| commit | 22216ec41e919682c15345e95928f266e8ba6f9e (patch) | |
| tree | 17719e057990475eba47471d94be64b4686091e6 /tools/perf/scripts/python | |
| parent | 30ed2b83343bd1e07884ca7355dac70d25ffc158 (diff) | |
media: soc_camera: ov772x: correct setting of banding filter
The banding filter ON/OFF is controlled via bit 5 of COM8 register. It
is attempted to be enabled in ov772x_set_params() by the following line.
ret = ov772x_mask_set(client, COM8, BNDF_ON_OFF, 1);
But this unexpectedly results disabling the banding filter, because the
mask and set bits are exclusive.
On the other hand, ov772x_s_ctrl() correctly sets the bit by:
ret = ov772x_mask_set(client, COM8, BNDF_ON_OFF, BNDF_ON_OFF);
The same fix was already applied to non-soc_camera version of ov772x
driver in the commit commit a024ee14cd36 ("media: ov772x: correct setting
of banding filter")
Cc: Jacopo Mondi <[email protected]>
Cc: Laurent Pinchart <[email protected]>
Cc: Hans Verkuil <[email protected]>
Signed-off-by: Akinobu Mita <[email protected]>
Signed-off-by: Sakari Ailus <[email protected]>
Signed-off-by: Mauro Carvalho Chehab <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python')
0 files changed, 0 insertions, 0 deletions