diff options
| author | Arnd Bergmann <[email protected]> | 2024-01-09 10:06:39 +0100 |
|---|---|---|
| committer | Lee Jones <[email protected]> | 2024-03-07 08:48:02 +0000 |
| commit | 211f8ec9400b58fb97cf4b6bd7033781e889bf53 (patch) | |
| tree | 0bd12baa186252a73cafbc31104ec3fe3ba1e59a /tools/perf/scripts/python | |
| parent | d0532248df7111428abd12875c90c34a39a546e4 (diff) | |
leds: Remove led_init_default_state_get() and devm_led_classdev_register_ext() stubs
These two functions have stub implementations that are called when
NEW_LEDS and/or LEDS_CLASS are disabled, theorerically allowing drivers
to optionally use the LED subsystem.
However, this has never really worked because a built-in driver is
unable to link against these functions if the LED class is in a loadable
module. Heiner ran into this problem with a driver that newly gained
a LEDS_CLASS dependency and suggested using an IS_REACHABLE() check.
This is the reverse approach, removing the stub entirely to acknowledge
that it is pointless in its current form, and that not having it avoids
misleading developers into thinking that they can rely on it.
This survived around 1000 randconfig builds to validate that any callers
of the interface already have the correct Kconfig dependency already,
with the exception of the one that Heiner just added.
Cc: Heiner Kallweit <[email protected]>
Link: https://lore.kernel.org/linux-leds/[email protected]/T/#u
Signed-off-by: Arnd Bergmann <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Lee Jones <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python')
0 files changed, 0 insertions, 0 deletions