diff options
| author | Tomi Valkeinen <[email protected]> | 2024-04-24 18:39:07 +0300 |
|---|---|---|
| committer | Hans Verkuil <[email protected]> | 2024-06-04 08:31:24 +0200 |
| commit | 1d7804281df3f09f0a109d00406e859a00bae7ae (patch) | |
| tree | 53c1ccdd8542af1a62106f13e0a9e92655016fc3 /tools/perf/scripts/python | |
| parent | e003fd9c1e3883a96451d24174dc5bad2c248341 (diff) | |
media: subdev: Fix use of sd->enabled_streams in call_s_stream()
call_s_stream() uses sd->enabled_streams to track whether streaming has
already been enabled. However,
v4l2_subdev_enable/disable_streams_fallback(), which was the original
user of this field, already uses it, and
v4l2_subdev_enable/disable_streams_fallback() will call call_s_stream().
This leads to a conflict as both functions set the field. Afaics, both
functions set the field to the same value, so it won't cause a runtime
bug, but it's still wrong and if we, e.g., change how
v4l2_subdev_enable/disable_streams_fallback() operates we might easily
cause bugs.
Fix this by adding a new field, 's_stream_enabled', for
call_s_stream().
Reviewed-by: Umang Jain <[email protected]>
Reviewed-by: Laurent Pinchart <[email protected]>
Tested-by: Umang Jain <[email protected]>
Signed-off-by: Tomi Valkeinen <[email protected]>
Signed-off-by: Sakari Ailus <[email protected]>
Signed-off-by: Hans Verkuil <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python')
0 files changed, 0 insertions, 0 deletions