diff options
author | Íñigo Huguet <[email protected]> | 2022-09-14 13:11:35 +0200 |
---|---|---|
committer | Jakub Kicinski <[email protected]> | 2022-09-19 18:09:55 -0700 |
commit | 0a242eb2913a4aa3d6fbdb86559f27628e9466f3 (patch) | |
tree | d093188d4b2efb30d98ad3f794e1dd8bd8b27177 /tools/perf/scripts/python | |
parent | f232af4295653afa4ade3230462b3be15ad16419 (diff) |
sfc: fix null pointer dereference in efx_hard_start_xmit
Trying to get the channel from the tx_queue variable here is wrong
because we can only be here if tx_queue is NULL, so we shouldn't
dereference it. As the above comment in the code says, this is very
unlikely to happen, but it's wrong anyway so let's fix it.
I hit this issue because of a different bug that caused tx_queue to be
NULL. If that happens, this is the error message that we get here:
BUG: unable to handle kernel NULL pointer dereference at 0000000000000020
[...]
RIP: 0010:efx_hard_start_xmit+0x153/0x170 [sfc]
Fixes: 12804793b17c ("sfc: decouple TXQ type from label")
Reported-by: Tianhao Zhao <[email protected]>
Signed-off-by: Íñigo Huguet <[email protected]>
Acked-by: Edward Cree <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Jakub Kicinski <[email protected]>
Diffstat (limited to 'tools/perf/scripts/python')
0 files changed, 0 insertions, 0 deletions